Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: webrtc/call/call.cc

Issue 2505873002: Fix unit for logged bitrates at the end of a call. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 2f69cf46275ec4d466557644b3f79575d0720454..baa89366c78e11b617d30c04f97736f72aabef3b 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -369,7 +369,7 @@ void Call::UpdateReceiveHistograms() {
if (video_bytes_per_sec.num_samples > kMinRequiredPeriodicSamples) {
RTC_HISTOGRAM_COUNTS_100000("WebRTC.Call.VideoBitrateReceivedInKbps",
video_bytes_per_sec.average * 8 / 1000);
- LOG(LS_INFO) << "WebRTC.Call.VideoBitrateReceivedInKbps, "
+ LOG(LS_INFO) << "WebRTC.Call.VideoBitrateReceivedInBytesPerSec, "
stefan-webrtc 2016/11/16 08:05:34 Why bytes per sec? I think it makes more sense to
<< video_bytes_per_sec.ToString();
}
AggregatedStats audio_bytes_per_sec =
@@ -377,7 +377,7 @@ void Call::UpdateReceiveHistograms() {
if (audio_bytes_per_sec.num_samples > kMinRequiredPeriodicSamples) {
RTC_HISTOGRAM_COUNTS_100000("WebRTC.Call.AudioBitrateReceivedInKbps",
audio_bytes_per_sec.average * 8 / 1000);
- LOG(LS_INFO) << "WebRTC.Call.AudioBitrateReceivedInKbps, "
+ LOG(LS_INFO) << "WebRTC.Call.AudioBitrateReceivedInBytesPerSec, "
<< audio_bytes_per_sec.ToString();
}
AggregatedStats rtcp_bytes_per_sec =
@@ -385,7 +385,7 @@ void Call::UpdateReceiveHistograms() {
if (rtcp_bytes_per_sec.num_samples > kMinRequiredPeriodicSamples) {
RTC_HISTOGRAM_COUNTS_100000("WebRTC.Call.RtcpBitrateReceivedInBps",
rtcp_bytes_per_sec.average * 8);
- LOG(LS_INFO) << "WebRTC.Call.RtcpBitrateReceivedInBps, "
+ LOG(LS_INFO) << "WebRTC.Call.RtcpBitrateReceivedInBytesPerSec, "
<< rtcp_bytes_per_sec.ToString();
}
AggregatedStats recv_bytes_per_sec =
@@ -393,7 +393,7 @@ void Call::UpdateReceiveHistograms() {
if (recv_bytes_per_sec.num_samples > kMinRequiredPeriodicSamples) {
RTC_HISTOGRAM_COUNTS_100000("WebRTC.Call.BitrateReceivedInKbps",
recv_bytes_per_sec.average * 8 / 1000);
- LOG(LS_INFO) << "WebRTC.Call.BitrateReceivedInKbps, "
+ LOG(LS_INFO) << "WebRTC.Call.BitrateReceivedInBytesPerSec, "
<< recv_bytes_per_sec.ToString();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698