Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2505873002:
Fix unit for logged bitrates at the end of a call. (Closed)
|
Created:
4 years, 1 month ago by åsapersson Modified:
4 years, 1 month ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix unit for logged bitrates at the end of a call.
BUG=webrtc:5283
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/a814941e141c81434fca27468fb47c78fab38edf
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 ========== to ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 ==========
asapersson@webrtc.org changed reviewers: + stefan@webrtc.org
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2505873002/diff/1/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2505873002/diff/1/webrtc/call/call.cc#newcode372 webrtc/call/call.cc:372: LOG(LS_INFO) << "WebRTC.Call.VideoBitrateReceivedInBytesPerSec, " Why bytes per sec? I think it makes more sense to use bits or kbits?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16118)
lgtm
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16125)
Message was sent while issue was closed.
Description was changed from ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 ========== to ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 R=stefan@webrtc.org Committed: https://crrev.com/a814941e141c81434fca27468fb47c78fab38edf Cr-Commit-Position: refs/heads/master@{#15100} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a814941e141c81434fca27468fb47c78fab38edf Cr-Commit-Position: refs/heads/master@{#15100}
Message was sent while issue was closed.
Description was changed from ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 R=stefan@webrtc.org Committed: https://crrev.com/a814941e141c81434fca27468fb47c78fab38edf Cr-Commit-Position: refs/heads/master@{#15100} ========== to ========== Fix unit for logged bitrates at the end of a call. BUG=webrtc:5283 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a814941e141c81434fca27468... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as a814941e141c81434fca27468fb47c78fab38edf (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
