Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2505183003: MB: Add new perf desktop bots and remove DCHECK from Android perf (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add new perf desktop bots and remove DCHECK from Android perf Add new perf desktop bots. Remove dcheck_always_on=true for all perf bots. Cleanup some more GYP traces. Remove gn_ prefix for all mixins for readability. BUG=chromium:665874 NOTRY=True Committed: https://crrev.com/de4980311c01264baf29011afc7c40fc37c7dd18 Cr-Commit-Position: refs/heads/master@{#15138}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -145 lines) Patch
M webrtc/build/mb_config.pyl View 1 4 chunks +157 lines, -145 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 1 month ago (2016-11-16 22:10:23 UTC) #2
ehmaldonado_webrtc
On 2016/11/16 22:10:23, kjellander_webrtc wrote: LGTM
4 years, 1 month ago (2016-11-16 22:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505183003/20001
4 years, 1 month ago (2016-11-17 15:45:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 15:47:13 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 15:47:24 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de4980311c01264baf29011afc7c40fc37c7dd18
Cr-Commit-Position: refs/heads/master@{#15138}

Powered by Google App Engine
This is Rietveld 408576698