Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2505173002: Added a callback function OnAddTrack to PeerConnectionObserver (Closed)
Patch Set: Simple change on java and obj-c. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 586
587 // Ice candidates have been removed. 587 // Ice candidates have been removed.
588 // TODO(honghaiz): Make this a pure virtual method when all its subclasses 588 // TODO(honghaiz): Make this a pure virtual method when all its subclasses
589 // implement it. 589 // implement it.
590 virtual void OnIceCandidatesRemoved( 590 virtual void OnIceCandidatesRemoved(
591 const std::vector<cricket::Candidate>& candidates) {} 591 const std::vector<cricket::Candidate>& candidates) {}
592 592
593 // Called when the ICE connection receiving status changes. 593 // Called when the ICE connection receiving status changes.
594 virtual void OnIceConnectionReceivingChange(bool receiving) {} 594 virtual void OnIceConnectionReceivingChange(bool receiving) {}
595 595
596 // Called when a track is added to streams.
597 virtual void OnAddTrack(
598 rtc::scoped_refptr<RtpReceiverInterface> receiver,
599 std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams) = 0;
Taylor Brandstetter 2016/11/17 00:34:23 Since Chromium has PeerConnectionObserver subclass
Zhi Huang 2016/11/17 01:42:06 Ah, I see. I thought that "TODO" is something we c
600
596 protected: 601 protected:
597 // Dtor protected as objects shouldn't be deleted via this interface. 602 // Dtor protected as objects shouldn't be deleted via this interface.
598 ~PeerConnectionObserver() {} 603 ~PeerConnectionObserver() {}
599 }; 604 };
600 605
601 // PeerConnectionFactoryInterface is the factory interface use for creating 606 // PeerConnectionFactoryInterface is the factory interface use for creating
602 // PeerConnection, MediaStream and media tracks. 607 // PeerConnection, MediaStream and media tracks.
603 // PeerConnectionFactoryInterface will create required libjingle threads, 608 // PeerConnectionFactoryInterface will create required libjingle threads,
604 // socket and network manager factory classes for networking. 609 // socket and network manager factory classes for networking.
605 // If an application decides to provide its own threads and network 610 // If an application decides to provide its own threads and network
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 cricket::WebRtcVideoEncoderFactory* encoder_factory, 762 cricket::WebRtcVideoEncoderFactory* encoder_factory,
758 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 763 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
759 return CreatePeerConnectionFactory( 764 return CreatePeerConnectionFactory(
760 worker_and_network_thread, worker_and_network_thread, signaling_thread, 765 worker_and_network_thread, worker_and_network_thread, signaling_thread,
761 default_adm, encoder_factory, decoder_factory); 766 default_adm, encoder_factory, decoder_factory);
762 } 767 }
763 768
764 } // namespace webrtc 769 } // namespace webrtc
765 770
766 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 771 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698