Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2505093003: Fix a bug when using gtest-parallel on swarming (plus flag related changes). (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed a bug where only the tests in the first shard were run. This is because: 1) The environment variables were still around when the test was executed. 2) gtest-parallel executes only one test at a time. So when the test was invoked from a shard different than the 0th one, for example as: ./something_unittests --gtest_filter=Test.Name It read the environment variables, and the environment variables together with the gtest_filter flag, told it that there were several shards, but only one test to be run, so if it wasn't the 0th shard, it wouldn't run the test at all. This is fixed by erasing the environment variables once read. Also change swarming-related flag names to fit the rest of the flags and validate their values. NOTRY=True BUG=chromium:497757, chromium:664425 TBR=pbos@webrtc.org, kjellander@webrtc.org Committed: https://crrev.com/aee0b5d31737f476e5c3ea2eb34e00a6f101caea Cr-Commit-Position: refs/heads/master@{#15110}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed a bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/gtest-parallel/gtest-parallel View 1 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
ehmaldonado_webrtc
https://codereview.webrtc.org/2505093003/diff/1/third_party/gtest-parallel/gtest-parallel File third_party/gtest-parallel/gtest-parallel (right): https://codereview.webrtc.org/2505093003/diff/1/third_party/gtest-parallel/gtest-parallel#newcode269 third_party/gtest-parallel/gtest-parallel:269: parser.add_option('--shard_count', type='int', I decided to leave it as 'int' ...
4 years, 1 month ago (2016-11-16 21:17:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505093003/40001
4 years, 1 month ago (2016-11-17 00:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505093003/40001
4 years, 1 month ago (2016-11-17 00:29:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/6891) win_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 00:32:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505093003/40001
4 years, 1 month ago (2016-11-17 00:45:32 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-17 00:48:16 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 00:48:20 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aee0b5d31737f476e5c3ea2eb34e00a6f101caea
Cr-Commit-Position: refs/heads/master@{#15110}

Powered by Google App Engine
This is Rietveld 408576698