Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2504783002: Revert of Start probes only after network is connected. (Closed)

Created:
4 years, 1 month ago by honghaiz3
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Start probes only after network is connected. (patchset #9 id:240001 of https://codereview.webrtc.org/2458863002/ ) Reason for revert: It broke downstream test. Original issue's description: > Start probes only after network is connected. > > Previously ProbeController was starting probing as soon as SetBitrates() > is called. As result these probes would often timeout while connection > is being established. Now ProbeController receives notifications about > network route changes. This allows to start probing only when transport > is connected. This also makes it possible to restart probing whenever > transport route changes (will be done in a separate change). > > BUG=webrtc:6332 > > Committed: https://crrev.com/5c99c76255ee7bface3c742c25fb5617748ac86e > Cr-Commit-Position: refs/heads/master@{#15094} TBR=philipel@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6332 Committed: https://crrev.com/906c5dc6b79aee2a6a1fb0a97372838092a030bf Cr-Commit-Position: refs/heads/master@{#15098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -96 lines) Patch
M webrtc/call/bitrate_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.h View 2 chunks +3 lines, -11 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.cc View 2 chunks +17 lines, -40 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/test/direct_transport.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
honghaiz3
Created Revert of Start probes only after network is connected.
4 years, 1 month ago (2016-11-15 22:38:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2504783002/1
4 years, 1 month ago (2016-11-15 22:38:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 22:39:11 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:39:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/906c5dc6b79aee2a6a1fb0a97372838092a030bf
Cr-Commit-Position: refs/heads/master@{#15098}

Powered by Google App Engine
This is Rietveld 408576698