Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2504643002: Fix Android lint error. (Closed)

Created:
4 years, 1 month ago by sakal
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Android lint error. BUG=webrtc:6711 NOTRY=True Committed: https://crrev.com/e19649b8ce352081cf0916b818c292aa3fdeeda0 Cr-Commit-Position: refs/heads/master@{#15095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/examples/androidapp/res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
PTAL This fixes the lint error in local testing. The import order change is due ...
4 years, 1 month ago (2016-11-15 15:50:58 UTC) #3
kjellander_webrtc
lgtm please land with NOTRY=True
4 years, 1 month ago (2016-11-15 16:15:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2504643002/1
4 years, 1 month ago (2016-11-15 20:30:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 20:32:26 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:36:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e19649b8ce352081cf0916b818c292aa3fdeeda0
Cr-Commit-Position: refs/heads/master@{#15095}

Powered by Google App Engine
This is Rietveld 408576698