Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2504103002: Adding GetConfiguration to PeerConnection. (Closed)

Created:
4 years, 1 month ago by Taylor Brandstetter
Modified:
4 years, 1 month ago
Reviewers:
honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding GetConfiguration to PeerConnection. Just returns the configuration the PC was constructed with, or the last one passed into SetConfiguration. BUG=chromium:587453 Committed: https://crrev.com/46c7389a63f71923d605d7851d956656ffbac4b3 Cr-Commit-Position: refs/heads/master@{#15111}

Patch Set 1 #

Patch Set 2 : Fixing typo in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M webrtc/api/peerconnection.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/peerconnection.cc View 6 chunks +13 lines, -5 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
honghaiz3
lgtm
4 years, 1 month ago (2016-11-17 01:25:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2504103002/20001
4 years, 1 month ago (2016-11-17 03:39:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 03:42:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 03:42:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46c7389a63f71923d605d7851d956656ffbac4b3
Cr-Commit-Position: refs/heads/master@{#15111}

Powered by Google App Engine
This is Rietveld 408576698