Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: webrtc/modules/pacing/alr_detector.cc

Issue 2504023002: Implement periodic bandwidth probing in application-limited region. (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/alr_detector.cc
diff --git a/webrtc/modules/pacing/alr_detector.cc b/webrtc/modules/pacing/alr_detector.cc
index 90afe18fef76a3368d1db725e758c5d31ffee8e9..77d23824ea239453a2272a5c981f1a0b71767d34 100644
--- a/webrtc/modules/pacing/alr_detector.cc
+++ b/webrtc/modules/pacing/alr_detector.cc
@@ -44,10 +44,10 @@ void AlrDetector::OnBytesSent(size_t bytes_sent, int64_t now_ms) {
return;
int percentage = static_cast<int>(*rate) * 100 / estimated_bitrate_bps_;
- if (percentage < kAlrStartUsagePercent && !application_limited_) {
- application_limited_ = true;
- } else if (percentage > kAlrEndUsagePercent && application_limited_) {
- application_limited_ = false;
+ if (percentage < kAlrStartUsagePercent && !alr_started_time_ms_) {
+ alr_started_time_ms_ = now_ms;
+ } else if (percentage > kAlrEndUsagePercent && alr_started_time_ms_) {
+ alr_started_time_ms_ = 0;
}
}
@@ -56,8 +56,11 @@ void AlrDetector::SetEstimatedBitrate(int bitrate_bps) {
estimated_bitrate_bps_ = bitrate_bps;
}
-bool AlrDetector::InApplicationLimitedRegion() const {
- return application_limited_;
+rtc::Optional<int64_t> AlrDetector::GetApplicationLimitedRegionStartTime()
+ const {
+ return alr_started_time_ms_ == 0
+ ? rtc::Optional<int64_t>()
stefan-webrtc 2016/11/28 13:27:13 I would have made alr_started_time_ms_ an rtc::Opt
Sergey Ulanov 2016/11/28 20:39:00 Done.
+ : rtc::Optional<int64_t>(alr_started_time_ms_);
}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698