webrtc/base/smoothing_filter.cc - Issue 2503713003: Smooth BWE and pass it to Audio Network Adaptor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/base/smoothing_filter.cc

Issue 2503713003: Smooth BWE and pass it to Audio Network Adaptor. (Closed)

Patch Set: Response to comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/base/smoothing_filter.h ('k') | webrtc/voice_engine/channel.h » ('j') | webrtc/voice_engine/channel.cc » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 filter_.Apply(static_cast<float>(last_sample_time_ms_ - now_ms), sample);	52 filter_.Apply(static_cast<float>(last_sample_time_ms_ - now_ms), sample);

53 last_sample_time_ms_ = now_ms;	53 last_sample_time_ms_ = now_ms;

54 }	54 }

55	55

56 rtc::Optional<float> SmoothingFilterImpl::GetAverage() const {	56 rtc::Optional<float> SmoothingFilterImpl::GetAverage() const {

57 float value = filter_.filtered();	57 float value = filter_.filtered();

58 return value == rtc::ExpFilter::kValueUndefined ? rtc::Optional<float>()	58 return value == rtc::ExpFilter::kValueUndefined ? rtc::Optional<float>()

59 : rtc::Optional<float>(value);	59 : rtc::Optional<float>(value);

60 }	60 }

61	61

	62 void SmoothingFilterImpl::SetTimeConstantMs(int time_constant_ms) {

	63 time_constant_ms_ = time_constant_ms;

	64 filter_.UpdateBase(exp(1.0f / time_constant_ms_));
	minyue-webrtc 2016/11/21 09:18:24 is this needed. Don't we always decide to updateBa is this needed. Don't we always decide to updateBase in AddSample? michaelt 2016/11/21 09:48:32 Just in the case the filter is not initialized. Just in the case the filter is not initialized. minyue-webrtc 2016/11/21 10:59:01 I see... BTW, you mean "it IS initialized" don't y Show quoted text On 2016/11/21 09:48:32, michaelt wrote: > Just in the case the filter is not initialized. > I see... BTW, you mean "it IS initialized" don't you?
	65 }

	66

62 } // namespace webrtc	67 } // namespace webrtc

OLD	NEW