Add FlexFEC end-to-end test.

Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
Committed: https://crrev.com/1e3dfbfc2b098e8e2c1dcf355ab41e6b1f839a0c
Cr-Commit-Position: refs/heads/master@{#15113}

[brandtr, 2016-11-15 11:30:04]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[brandtr, 2016-11-15 11:30:05]

Please have initial look at this WIP CL.

The bulk of this code is basically copied from the corresponding Ulpfec test.

This test will currently not pass, due to some issues with how the RTP send
stats are collected. A CL fixing that is coming.

[brandtr, 2016-11-15 11:36:04]

Description was changed from

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
==========

to

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
==========

[brandtr, 2016-11-15 11:36:04]

brandtr@webrtc.org changed reviewers:
+ nisse@webrtc.org

[brandtr, 2016-11-15 14:13:33]

Rebase on top of initial stats CL.

[stefan-webrtc, 2016-11-15 14:21:44]

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:689: if
(protected_sequence_numbers_.count(header.sequenceNumber) != 0) {
I prefer find() over count as it's cheaper.

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:691:
protected_sequence_numbers_.erase(header.sequenceNumber);
And then you can erase what you found here.

[brandtr, 2016-11-15 14:29:48]

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:689: if
(protected_sequence_numbers_.count(header.sequenceNumber) != 0) {
On 2016/11/15 14:21:44, stefan-webrtc (holmer) wrote:
> I prefer find() over count as it's cheaper.

Done.

https://codereview.webrtc.org/2503633004/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:691:
protected_sequence_numbers_.erase(header.sequenceNumber);
On 2016/11/15 14:21:44, stefan-webrtc (holmer) wrote:
> And then you can erase what you found here.

Done.

[stefan-webrtc, 2016-11-15 14:34:08]

lgtm

[brandtr, 2016-11-15 16:24:13]

Rebase.

[brandtr, 2016-11-15 16:33:39]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-11-15 16:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2503633004/#ps80001 (title:
"Replace count with find in one more place.")

[commit-bot: I haz the power, 2016-11-15 16:33:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2016-11-15 16:48:27]

The CQ bit was unchecked by brandtr@webrtc.org

[nisse-webrtc, 2016-11-16 07:45:28]

lgtm

https://codereview.webrtc.org/2503633004/diff/80001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2503633004/diff/80001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:748: << "Timed out waiting for dropped frames
frames to be rendered.";
Repeated word.

[brandtr, 2016-11-16 07:48:41]

https://codereview.webrtc.org/2503633004/diff/80001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2503633004/diff/80001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:748: << "Timed out waiting for dropped frames
frames to be rendered.";
On 2016/11/16 07:45:27, nisse-webrtc wrote:
> Repeated word.

Fixed.

[brandtr, 2016-11-16 08:17:40]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-11-16 08:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2503633004/#ps100001 (title:
"Feedback response 2.")

[commit-bot: I haz the power, 2016-11-16 08:17:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-16 08:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 08:23:03]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16239)

[brandtr, 2016-11-16 10:18:37]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-16 10:18:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-16 10:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 10:31:52]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16134)

[brandtr, 2016-11-16 16:23:18]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-16 16:23:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-16 16:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 16:44:25]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16175)

[brandtr, 2016-11-17 06:36:58]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-17 06:37:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 06:45:21]

Description was changed from

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
==========

to

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-11-17 06:45:22]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-17 06:45:33]

Description was changed from

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654
==========

to

==========
Add FlexFEC end-to-end test.

Verifies correct reception of FlexFEC packets.

BUG=webrtc:5654

Committed: https://crrev.com/1e3dfbfc2b098e8e2c1dcf355ab41e6b1f839a0c
Cr-Commit-Position: refs/heads/master@{#15113}
==========

[commit-bot: I haz the power, 2016-11-17 06:45:34]

Patchset 6 (id:??) landed as
https://crrev.com/1e3dfbfc2b098e8e2c1dcf355ab41e6b1f839a0c
Cr-Commit-Position: refs/heads/master@{#15113}