Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2503523003:
Add VideoSendStreamTest for FlexFEC. (Closed)
DescriptionAdd VideoSendStreamTest for FlexFEC.
Verifies correct sending of FlexFEC packets.
BUG=webrtc:5654
Committed: https://crrev.com/39f9729c7ab01bbc4780ef08f7c63cf9f5937215
Cr-Commit-Position: refs/heads/master@{#15115}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Feedback response 1. #Patch Set 3 : Rebase on top of initial stats CL. #Patch Set 4 : Rebase. #Patch Set 5 : Remove unused member variable. #Messages
Total messages: 24 (13 generated)
brandtr@webrtc.org changed reviewers: + stefan@webrtc.org
Dito.
Description was changed from ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 ========== to ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 ==========
brandtr@webrtc.org changed reviewers: + nisse@webrtc.org
lg https://codereview.webrtc.org/2503523003/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2503523003/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:596: EXPECT_EQ(1, seq_num_diff); Do you think it's necessary to verify that the extensions are set correctly here, or enough to check that they are set?
lgtm
https://codereview.webrtc.org/2503523003/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2503523003/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:596: EXPECT_EQ(1, seq_num_diff); On 2016/11/15 12:29:53, stefan-webrtc (holmer) wrote: > Do you think it's necessary to verify that the extensions are set correctly > here, or enough to check that they are set? It's enough to just check that they are set. Also makes the code a bit easier to read here. I added toffset as well.
Rebase on top of initial stats CL.
Rebase.
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16122)
The CQ bit was checked by brandtr@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2503523003/#ps80001 (title: "Remove unused member variable.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16135)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 ========== to ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 ========== to ========== Add VideoSendStreamTest for FlexFEC. Verifies correct sending of FlexFEC packets. BUG=webrtc:5654 Committed: https://crrev.com/39f9729c7ab01bbc4780ef08f7c63cf9f5937215 Cr-Commit-Position: refs/heads/master@{#15115} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/39f9729c7ab01bbc4780ef08f7c63cf9f5937215 Cr-Commit-Position: refs/heads/master@{#15115} |
