Let Opus increase complexity for low bitrates

Let Opus increase complexity for low bitrates

This change adds code that lets Opus increase the complexity setting
at low bitrates (only relevant for mobile where the default complexity
is not already maximum). The feature is default off.

Also adding a performance test to make sure the complexity adaptation
has desired effect.

BUG=webrtc:6708
Committed: https://crrev.com/875862ca86b5aec6445e02723676d4a8fcbb42a6
Cr-Commit-Position: refs/heads/master@{#15182}

[hlundin-webrtc, 2016-11-14 13:17:35]

henrik.lundin@webrtc.org changed reviewers:
+ minyue@webrtc.org

[hlundin-webrtc, 2016-11-14 13:17:35]

Minyue,

Please, take a look.

[hlundin-webrtc, 2016-11-21 12:18:59]

On 2016/11/14 13:17:35, hlundin-webrtc wrote:
> Minyue,
> 
> Please, take a look.

Minyue, I added a hysteresis implementation now. I'm willing to consider other
implementations, if you have suggestions.

[minyue-webrtc, 2016-11-22 09:48:34]

lgtm and land this first, may consider adding a unittest on the margin (as a
follow-up cl)

https://codereview.webrtc.org/2503443002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2503443002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:59: //
mobiles, the regular complexity is 5, and we expect the resulting ration to
ratio

[hlundin-webrtc, 2016-11-22 09:52:21]

Thanks!

https://codereview.webrtc.org/2503443002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2503443002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:59: //
mobiles, the regular complexity is 5, and we expect the resulting ration to
On 2016/11/22 09:48:34, minyue-webrtc wrote:
> ratio

Done.

[hlundin-webrtc, 2016-11-22 09:52:26]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-11-22 09:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2503443002/#ps40001 (title:
"Fixing a typo")

[commit-bot: I haz the power, 2016-11-22 09:52:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 10:07:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479808346706470,
"parent_rev": "2853f100e6628597ec9a091adf726ade2a9320b7", "commit_rev":
"be6dac3263e9fc478c7f20df3d2f32bcdbe4d585"}

[commit-bot: I haz the power, 2016-11-22 10:08:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 10:08:04]

Description was changed from

==========
Let Opus increase complexity for low bitrates

This change adds code that lets Opus increase the complexity setting
at low bitrates (only relevant for mobile where the default complexity
is not already maximum). The feature is default off.

Also adding a performance test to make sure the complexity adaptation
has desired effect.

BUG=webrtc:6708
==========

to

==========
Let Opus increase complexity for low bitrates

This change adds code that lets Opus increase the complexity setting
at low bitrates (only relevant for mobile where the default complexity
is not already maximum). The feature is default off.

Also adding a performance test to make sure the complexity adaptation
has desired effect.

BUG=webrtc:6708

Committed: https://crrev.com/875862ca86b5aec6445e02723676d4a8fcbb42a6
Cr-Commit-Position: refs/heads/master@{#15182}
==========

[commit-bot: I haz the power, 2016-11-22 10:08:04]

Patchset 3 (id:??) landed as
https://crrev.com/875862ca86b5aec6445e02723676d4a8fcbb42a6
Cr-Commit-Position: refs/heads/master@{#15182}