Add support for FEC-FR semantics in StreamParams.

Add support for FEC-FR semantics in StreamParams.

This allows us to associate a FlexFEC SSRC with a
media SSRC in the SDP.

BUG=webrtc:5654
R=magjed@webrtc.org
CC=stefan@webrtc.org, perkj@webrtc.org

Committed: https://crrev.com/9688e384e6ae8f214624d9dc0d869152b9e86eb3
Cr-Commit-Position: refs/heads/master@{#15177}

[brandtr, 2016-11-17 11:34:43]

[Same message for three related CLs.]

Please take a look at this change :)

To make it easier to review, I have split a set of related changes into three
dependent CLs. The CLs have different reviewers, but you are CC'd on the ones
where I didn't set you as a reviewer.

Review
==
holmer: config.h
magjed: media/
perkj: pc/

Overview
==
This set of CLs add support for FlexFEC (see
https://tools.ietf.org/html/draft-ietf-payload-flexible-fec-scheme-03) in
MediaSession, StreamParams, and VideoEngine2. After these changes, FlexFEC can
be exposed in the SDP and the corresponding config will be propagated down to
the Call level. This is not turned on by default, but instead hidden between a
field trial.

Changes
==
StreamParams: Adds support for the FEC-FR grouping semantics.

MediaSession: Whenever FlexFEC is added to the list of codecs, a FlexFEC SSRC
will be generated, together with a FEC-FR grouping associating it with the
primary SSRC. See https://tools.ietf.org/html/rfc5956 for a description of the
FEC-FR grouping semantics. Simulcast is not yet supported.

VideoEngine2: Interfaces the SDP information with the Call level objects. The
FlexFEC payload type is picked up when the Send/Receive parameters are set. The
FlexFEC SSRC is picked up when a Send/Receive stream is added, if the FEC-FR
information is provided. The parameters are propagated down to a Call level,
where the corresponding VideoSendStream config is updated, and possibly a
FlexfecReceiveStream object is created.

[brandtr, 2016-11-17 16:09:59]

Rebase.

[brandtr, 2016-11-21 07:51:55]

Rebase.

[brandtr, 2016-11-21 07:53:09]

Patchset #3 (id:40001) has been deleted

[brandtr, 2016-11-21 08:44:01]

Rebase.

[brandtr, 2016-11-21 17:05:43]

Thanks for quick response on the other CL. That one is however dependent on this
one :)

Let me know if you have suggestions for other reviewers, to reduce your review
load here.

[magjed_webrtc, 2016-11-22 08:22:18]

Yeah, I'm not sure I'm the best reviewer of this (I'm unfamiliar with this part
of the code base), but this lgtm.

https://codereview.webrtc.org/2503403004/diff/60001/webrtc/media/base/streamp...
File webrtc/media/base/streamparams.h (right):

https://codereview.webrtc.org/2503403004/diff/60001/webrtc/media/base/streamp...
webrtc/media/base/streamparams.h:128: inline bool AddFecFrSsrc(uint32_t
primary_ssrc, uint32_t fecfr_ssrc) {
nit: you don't really need inline here since member functions defined in the
class declaration are implicitly marked inline.

[brandtr, 2016-11-22 08:40:30]

https://codereview.webrtc.org/2503403004/diff/60001/webrtc/media/base/streamp...
File webrtc/media/base/streamparams.h (right):

https://codereview.webrtc.org/2503403004/diff/60001/webrtc/media/base/streamp...
webrtc/media/base/streamparams.h:128: inline bool AddFecFrSsrc(uint32_t
primary_ssrc, uint32_t fecfr_ssrc) {
On 2016/11/22 08:22:18, magjed_webrtc wrote:
> nit: you don't really need inline here since member functions defined in the
> class declaration are implicitly marked inline.

Removed :)

[brandtr, 2016-11-22 08:40:48]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 08:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 08:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 08:57:24]

Dry run: This issue passed the CQ dry run.

[brandtr, 2016-11-22 08:58:29]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-11-22 08:58:30]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2503403004/#ps80001 (title:
"No inline inside class declaration.")

[commit-bot: I haz the power, 2016-11-22 08:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 08:59:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1479805109939950,
"parent_rev": "611e55cb65b1c2b362c74640951ccc07c6049f5c", "commit_rev":
"ef686433d9a8993a3eea1147de9d309beca2d1c6"}

[commit-bot: I haz the power, 2016-11-22 08:59:52]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-22 08:59:58]

Description was changed from

==========
Add support for FEC-FR semantics in StreamParams.

This allows us to associate a FlexFEC SSRC with a
media SSRC in the SDP.

BUG=webrtc:5654
R=magjed@webrtc.org
CC=stefan@webrtc.org, perkj@webrtc.org
==========

to

==========
Add support for FEC-FR semantics in StreamParams.

This allows us to associate a FlexFEC SSRC with a
media SSRC in the SDP.

BUG=webrtc:5654
R=magjed@webrtc.org
CC=stefan@webrtc.org, perkj@webrtc.org

Committed: https://crrev.com/9688e384e6ae8f214624d9dc0d869152b9e86eb3
Cr-Commit-Position: refs/heads/master@{#15177}
==========

[commit-bot: I haz the power, 2016-11-22 08:59:59]

Patchset 4 (id:??) landed as
https://crrev.com/9688e384e6ae8f214624d9dc0d869152b9e86eb3
Cr-Commit-Position: refs/heads/master@{#15177}