Expose RtpCodecParameters to VoiceMediaInfo stats.

webrtc/media/base/mediachannel.h

Index: webrtc/media/base/mediachannel.h
diff --git a/webrtc/media/base/mediachannel.h b/webrtc/media/base/mediachannel.h
index 80b9d4d44c23fb1fdd0c9a7d58ec3fe4401d9436..b662360f74710c773545db82893acca6dab73edc 100644
--- a/webrtc/media/base/mediachannel.h
+++ b/webrtc/media/base/mediachannel.h
@@ -553,6 +553,7 @@ struct MediaSenderInfo {
   float fraction_lost;
   int64_t rtt_ms;
   std::string codec_name;
+  rtc::Optional<uint32_t> codec_payload_type;
   std::vector<SsrcSenderInfo> local_stats;
   std::vector<SsrcReceiverInfo> remote_stats;
 };
@@ -598,6 +599,7 @@ struct MediaReceiverInfo {
   int packets_lost;
   float fraction_lost;
   std::string codec_name;
+  rtc::Optional<uint32_t> codec_payload_type;

[the sun, 2016/11/16 19:41:07]

Why uint32_t?
Payload types are 0-127, so if not just using an int, a uint8_t is a closer
match.

[Taylor Brandstetter, 2016/11/16 21:37:44]

I agree; I'd just use an int here, and use RTC_DCHECKs to assert that values are
in the 0-127 range, wherever necessary. Ultimately it needs to turn into an
"unsigned long", according to the W3C spec, but that can happen further up.

[hbos, 2016/11/17 14:14:48]

Done (using int). I picked uint32_t because that is the equivalent of "unsigned
long" in WebIDL, but I can restrict to that type when creating that stat.

   std::vector<SsrcReceiverInfo> local_stats;
   std::vector<SsrcSenderInfo> remote_stats;
 };
@@ -698,9 +700,6 @@ struct VideoSenderInfo : public MediaSenderInfo {
   std::vector<SsrcGroup> ssrc_groups;
   // TODO(hbos): Move this to |VideoMediaInfo::send_codecs|?
   std::string encoder_implementation_name;
-  // TODO(hbos): Move this to |MediaSenderInfo| when supported by
-  // |VoiceSenderInfo| as well (which also extends that class).
-  rtc::Optional<uint32_t> codec_payload_type;
   int packets_cached;
   int firs_rcvd;
   int plis_rcvd;
@@ -746,9 +745,6 @@ struct VideoReceiverInfo : public MediaReceiverInfo {
   std::vector<SsrcGroup> ssrc_groups;
   // TODO(hbos): Move this to |VideoMediaInfo::receive_codecs|?
   std::string decoder_implementation_name;
-  // TODO(hbos): Move this to |MediaReceiverInfo| when supported by
-  // |VoiceReceiverInfo| as well (which also extends that class).
-  rtc::Optional<uint32_t> codec_payload_type;
   int packets_concealed;
   int firs_sent;
   int plis_sent;
@@ -825,15 +821,19 @@ struct BandwidthEstimationInfo {
 };
 
 // Maps from payload type to |RtpCodecParameters|.
-typedef std::map<int, webrtc::RtpCodecParameters> RtpCodecParametersMap;
+typedef std::map<uint32_t, webrtc::RtpCodecParameters> RtpCodecParametersMap;
 
 struct VoiceMediaInfo {
   void Clear() {
     senders.clear();
     receivers.clear();
+    send_codecs.clear();
+    receive_codecs.clear();
   }
   std::vector<VoiceSenderInfo> senders;
   std::vector<VoiceReceiverInfo> receivers;
+  RtpCodecParametersMap send_codecs;
+  RtpCodecParametersMap receive_codecs;
 };
 
 struct VideoMediaInfo {