Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: webrtc/media/base/mediachannel.h

Issue 2503383002: Expose RtpCodecParameters to VoiceMediaInfo stats. (Closed)
Patch Set: Addressed comments, using int Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/mediachannel.h
diff --git a/webrtc/media/base/mediachannel.h b/webrtc/media/base/mediachannel.h
index 80b9d4d44c23fb1fdd0c9a7d58ec3fe4401d9436..d4d339eb6e7f5f61db4c1a666dfbb73377854466 100644
--- a/webrtc/media/base/mediachannel.h
+++ b/webrtc/media/base/mediachannel.h
@@ -553,6 +553,7 @@ struct MediaSenderInfo {
float fraction_lost;
int64_t rtt_ms;
std::string codec_name;
+ rtc::Optional<int> codec_payload_type;
std::vector<SsrcSenderInfo> local_stats;
std::vector<SsrcReceiverInfo> remote_stats;
};
@@ -598,6 +599,7 @@ struct MediaReceiverInfo {
int packets_lost;
float fraction_lost;
std::string codec_name;
+ rtc::Optional<int> codec_payload_type;
std::vector<SsrcReceiverInfo> local_stats;
std::vector<SsrcSenderInfo> remote_stats;
};
@@ -698,9 +700,6 @@ struct VideoSenderInfo : public MediaSenderInfo {
std::vector<SsrcGroup> ssrc_groups;
// TODO(hbos): Move this to |VideoMediaInfo::send_codecs|?
std::string encoder_implementation_name;
- // TODO(hbos): Move this to |MediaSenderInfo| when supported by
- // |VoiceSenderInfo| as well (which also extends that class).
- rtc::Optional<uint32_t> codec_payload_type;
int packets_cached;
int firs_rcvd;
int plis_rcvd;
@@ -746,9 +745,6 @@ struct VideoReceiverInfo : public MediaReceiverInfo {
std::vector<SsrcGroup> ssrc_groups;
// TODO(hbos): Move this to |VideoMediaInfo::receive_codecs|?
std::string decoder_implementation_name;
- // TODO(hbos): Move this to |MediaReceiverInfo| when supported by
- // |VoiceReceiverInfo| as well (which also extends that class).
- rtc::Optional<uint32_t> codec_payload_type;
int packets_concealed;
int firs_sent;
int plis_sent;
@@ -831,9 +827,13 @@ struct VoiceMediaInfo {
void Clear() {
senders.clear();
receivers.clear();
+ send_codecs.clear();
+ receive_codecs.clear();
}
std::vector<VoiceSenderInfo> senders;
std::vector<VoiceReceiverInfo> receivers;
+ RtpCodecParametersMap send_codecs;
+ RtpCodecParametersMap receive_codecs;
};
struct VideoMediaInfo {
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698