Expose RtpCodecParameters to VoiceMediaInfo stats.

webrtc/media/engine/webrtcvideoengine2.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1391 matching lines @@
        stream != send_streams_.end(); ++stream) {
     stream->second->FillBandwidthEstimationInfo(&bwe_info);
   }
   video_media_info->bw_estimations.push_back(bwe_info);
 }
 
 void WebRtcVideoChannel2::FillSendAndReceiveCodecStats(
     VideoMediaInfo* video_media_info) {
   for (const VideoCodec& codec : send_params_.codecs) {
     webrtc::RtpCodecParameters codec_params = codec.ToCodecParameters();
+    RTC_DCHECK_GE(codec_params.payload_type, 0);

[the sun, 2016/11/16 19:41:07]

Why are you DCHECKing this property here?

If the reason is just because of the cast to unsigned, change the map key type
to int instead.

If you want to make sure the payload type is something sane, you should also
check that it is <= 127 - and then it would be better to move the check into
RtpCodecParameters (making the field const, and adding DCHECks in the ctor) so
we don't have to remember DCHECKing in all places where we use the field.

[hbos, 2016/11/17 14:14:48]

Since RtpCodecParameter and the data structure it gets its value from all use
int, I'll make this code use int too.

Modifying it to DHCECK in its constructor is a good idea but just making its
members const removes the copy assignment operator and breaks code using
std::vector<RtpCodecParameter>. I don't want to do a bunch of refactoring in
this CL, so I'm just using int, this CL does not depend on the range of the
value anymore.

     video_media_info->send_codecs.insert(
-        std::make_pair(codec_params.payload_type, std::move(codec_params)));
+        std::make_pair(static_cast<uint32_t>(codec_params.payload_type),
+                       std::move(codec_params)));
   }
   for (const VideoCodec& codec : recv_params_.codecs) {
     webrtc::RtpCodecParameters codec_params = codec.ToCodecParameters();
+    RTC_DCHECK_GE(codec_params.payload_type, 0);
     video_media_info->receive_codecs.insert(
-        std::make_pair(codec_params.payload_type, std::move(codec_params)));
+        std::make_pair(static_cast<uint32_t>(codec_params.payload_type),
+                       std::move(codec_params)));
   }
 }
 
 void WebRtcVideoChannel2::OnPacketReceived(
     rtc::CopyOnWriteBuffer* packet,
     const rtc::PacketTime& packet_time) {
   const webrtc::PacketTime webrtc_packet_time(packet_time.timestamp,
                                               packet_time.not_before);
   const webrtc::PacketReceiver::DeliveryStatus delivery_result =
       call_->Receiver()->DeliverPacket(
@@ skipping 1161 matching lines @@
         rtx_mapping[video_codecs[i].codec.id] !=
             ulpfec_config.red_payload_type) {
       video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id];
     }
   }
 
   return video_codecs;
 }
 
 }  // namespace cricket