Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2502783005: Better delete of file in loopback script (Closed)

Created:
4 years, 1 month ago by mandermo
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Better delete of file in loopback script BUG=webrtc:6545 NOTRY=True Committed: https://crrev.com/007cdb59073778b86c71c37f302bdef32d767d4a Cr-Commit-Position: refs/heads/master@{#15102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mandermo
Better delete in the loopback script. Old code caused problems on newer Android versions.
4 years, 1 month ago (2016-11-15 15:54:39 UTC) #2
sakal
lgtm
4 years, 1 month ago (2016-11-15 16:03:24 UTC) #3
kjellander_webrtc
lgtm I added NOTRY=True for you.
4 years, 1 month ago (2016-11-15 17:54:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2502783005/1
4 years, 1 month ago (2016-11-16 10:28:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 10:31:28 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 10:31:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/007cdb59073778b86c71c37f302bdef32d767d4a
Cr-Commit-Position: refs/heads/master@{#15102}

Powered by Google App Engine
This is Rietveld 408576698