Introduce ArrayView::subview function

Introduce ArrayView::subview function
to return portion of the original view

BUG=None

Committed: https://crrev.com/a28780e994692f2494d8d54fb4539003a212dd6b
Cr-Commit-Position: refs/heads/master@{#15149}

[danilchap, 2016-11-17 17:21:09]

danilchap@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2016-11-18 01:57:36]

lgtm. Nice!

https://codereview.webrtc.org/2502383004/diff/1/webrtc/base/array_view.h
File webrtc/base/array_view.h (right):

https://codereview.webrtc.org/2502383004/diff/1/webrtc/base/array_view.h#newc...
webrtc/base/array_view.h:125: return nullptr;
It's probably good to add a comment saying that nullptr turns into an empty
ArrayView, or (better) just

  return ArrayView();

[danilchap, 2016-11-18 09:05:12]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2016-11-18 09:05:33]

https://codereview.webrtc.org/2502383004/diff/1/webrtc/base/array_view.h
File webrtc/base/array_view.h (right):

https://codereview.webrtc.org/2502383004/diff/1/webrtc/base/array_view.h#newc...
webrtc/base/array_view.h:125: return nullptr;
On 2016/11/18 01:57:36, kwiberg-webrtc wrote:
> It's probably good to add a comment saying that nullptr turns into an empty
> ArrayView, or (better) just
> 
>   return ArrayView();

Done.
(wasn't sure ArrayView() or nullptr give better hint it is an empty ArrayView.
1.5 votes for ArrayView now, 0.5 - for nullptr)

[commit-bot: I haz the power, 2016-11-18 09:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 09:29:29]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/18546)

[danilchap, 2016-11-18 09:31:30]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-11-18 09:31:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2502383004/#ps20001 (title:
"nullptr -> ArrayView()")

[commit-bot: I haz the power, 2016-11-18 09:31:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 09:46:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 09:46:33]

Description was changed from

==========
Introduce ArrayView::subview function
to return portion of the original view

BUG=None
==========

to

==========
Introduce ArrayView::subview function
to return portion of the original view

BUG=None

Committed: https://crrev.com/a28780e994692f2494d8d54fb4539003a212dd6b
Cr-Commit-Position: refs/heads/master@{#15149}
==========

[commit-bot: I haz the power, 2016-11-18 09:46:34]

Patchset 2 (id:??) landed as
https://crrev.com/a28780e994692f2494d8d54fb4539003a212dd6b
Cr-Commit-Position: refs/heads/master@{#15149}