Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2501893004: Simplify creating RtpHeaderExtensionMap in EventLogAnalyzer (Closed)

Created:
4 years, 1 month ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, ivoc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplify creating RtpHeaderExtensionMap in EventLogAnalyzer RtpHeaderExtensionMap constructor accept array view instead of initializer_list Remove now unused RtpHeaderExtensionMap::Erase BUG=webrtc:1994 Committed: https://crrev.com/4aecc5885a671200f2b3a33c51008cc635132dc4 Cr-Commit-Position: refs/heads/master@{#15090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 4 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 7 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
4 years, 1 month ago (2016-11-15 15:57:12 UTC) #2
terelius
lgtm Nice.
4 years, 1 month ago (2016-11-15 16:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2501893004/1
4 years, 1 month ago (2016-11-15 16:39:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 17:21:05 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 17:31:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4aecc5885a671200f2b3a33c51008cc635132dc4
Cr-Commit-Position: refs/heads/master@{#15090}

Powered by Google App Engine
This is Rietveld 408576698