Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2501603002: Removes usage of system_wrappers/include/clock.h in audio_device/ (Closed)

Created:
4 years, 1 month ago by henrika_webrtc
Modified:
4 years, 1 month ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes usage of system_wrappers/include/clock.h in audio_device/ BUG=webrtc:6687 NOTRY=TRUE Committed: https://crrev.com/92fd8e6b171a5b5534afaec28648af6fdc863d0f Cr-Commit-Position: refs/heads/master@{#15084}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : iOS #

Patch Set 4 : nit #

Patch Set 5 : Fixes FileAudioDevice #

Patch Set 6 : Now builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 1 2 6 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 1 2 3 4 5 5 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 1 2 3 5 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nisse-webrtc
https://codereview.webrtc.org/2501603002/diff/10002/webrtc/modules/audio_device/android/audio_device_unittest.cc File webrtc/modules/audio_device/android/audio_device_unittest.cc (right): https://codereview.webrtc.org/2501603002/diff/10002/webrtc/modules/audio_device/android/audio_device_unittest.cc#newcode1000 webrtc/modules/audio_device/android/audio_device_unittest.cc:1000: TEST_F(AudioDeviceTest, MeasureLoopbackLatency) { Nice it the test can now ...
4 years, 1 month ago (2016-11-15 08:12:33 UTC) #3
henrika_webrtc
PTAL ;-)
4 years, 1 month ago (2016-11-15 10:03:39 UTC) #4
nisse-webrtc
lgtm. Thanks.
4 years, 1 month ago (2016-11-15 12:22:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2501603002/90001
4 years, 1 month ago (2016-11-15 12:27:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/6831)
4 years, 1 month ago (2016-11-15 13:34:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2501603002/90001
4 years, 1 month ago (2016-11-15 13:36:23 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 1 month ago (2016-11-15 13:38:02 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 13:38:05 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/92fd8e6b171a5b5534afaec28648af6fdc863d0f
Cr-Commit-Position: refs/heads/master@{#15084}

Powered by Google App Engine
This is Rietveld 408576698