Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by brandtr Modified:
4 years, 1 month ago Reviewers:
marpan2, marpan, stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReplace c-style cast and constrain value in VCMFecMethod::ProtectionFactor.
BUG=None
Committed: https://crrev.com/05f845d025a8289851d7080501d1ff08e478e7f1
Cr-Commit-Position: refs/heads/master@{#15116}
Patch Set 1 : Use static_cast and std::min #
Total comments: 1
Patch Set 2 : Avoid wrap-around. #
Total comments: 2
Patch Set 3 : Feedback response 1. #
Created: 4 years, 1 month ago
Messages
Total messages: 29 (16 generated)
brandtr@webrtc.org changed reviewers: + marpan@webrtc.org
Hey marpan, Would you mind having a look at this change? https://codereview.webrtc.org/2501083003/diff/1/webrtc/modules/video_coding/m... File webrtc/modules/video_coding/media_opt_util.cc (right): https://codereview.webrtc.org/2501083003/diff/1/webrtc/modules/video_coding/m... webrtc/modules/video_coding/media_opt_util.cc:288: std::min(static_cast<float>(UINT8_MAX), I believe that when the min is active, this will lead to overflow?
marpan@google.com changed reviewers: + marpan@google.com
lgtm
stefan@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm https://codereview.webrtc.org/2501083003/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/media_opt_util.cc (right): https://codereview.webrtc.org/2501083003/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/media_opt_util.cc:287: std::min(static_cast<float>(UINT8_MAX), Use numeric_limits instead
https://codereview.webrtc.org/2501083003/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/media_opt_util.cc (right): https://codereview.webrtc.org/2501083003/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/media_opt_util.cc:287: std::min(static_cast<float>(UINT8_MAX), On 2016/11/15 19:21:02, stefan-webrtc (holmer) wrote: > Use numeric_limits instead Done.
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/8332)
The CQ bit was checked by brandtr@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from marpan@google.com, stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2501083003/#ps40001 (title: "Feedback response 1.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16119)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16152)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16174)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Replace c-style cast and constrain value in VCMFecMethod::ProtectionFactor. BUG=None ========== to ========== Replace c-style cast and constrain value in VCMFecMethod::ProtectionFactor. BUG=None Committed: https://crrev.com/05f845d025a8289851d7080501d1ff08e478e7f1 Cr-Commit-Position: refs/heads/master@{#15116} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/05f845d025a8289851d7080501d1ff08e478e7f1 Cr-Commit-Position: refs/heads/master@{#15116} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
