Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: webrtc/common_audio/signal_processing/vector_scaling_operations.c

Issue 2500953003: Avoid left-shifting negative values in a number of places (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_audio/signal_processing/vector_scaling_operations.c
diff --git a/webrtc/common_audio/signal_processing/vector_scaling_operations.c b/webrtc/common_audio/signal_processing/vector_scaling_operations.c
index fdefd0676079ad0ec409aa589ea459bb7afdc85e..e1f391d10a49ab66c1f90bbfba049a1fc3e8fe06 100644
--- a/webrtc/common_audio/signal_processing/vector_scaling_operations.c
+++ b/webrtc/common_audio/signal_processing/vector_scaling_operations.c
@@ -37,7 +37,7 @@ void WebRtcSpl_VectorBitShiftW16(int16_t *res, size_t length,
{
for (i = length; i > 0; i--)
{
- (*res++) = ((*in++) << (-right_shifts));
+ (*res++) = ((*in++) * (1 << (-right_shifts)));
}
}
}
« no previous file with comments | « webrtc/common_audio/signal_processing/levinson_durbin.c ('k') | webrtc/modules/audio_coding/neteq/expand.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698