Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2500943002: Add FlexFEC to CallTest. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add FlexFEC to CallTest. This is needed for the following coming tests: VideoSendStream, end-to-end, full stack, and video_loopback. BUG=webrtc:5654 Committed: https://crrev.com/841de6a47e6eb1b190ef6a9b1203ecc53c25f6a3 Cr-Commit-Position: refs/heads/master@{#15087}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -25 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/packet_injection_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/call_test.h View 6 chunks +14 lines, -0 lines 0 comments Download
M webrtc/test/call_test.cc View 16 chunks +64 lines, -4 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
brandtr
Please have a look :)
4 years, 1 month ago (2016-11-14 15:23:45 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-14 15:32:12 UTC) #3
nisse-webrtc
I'm afraid I'd need a little more context to understand what this is about. Can ...
4 years, 1 month ago (2016-11-15 08:43:00 UTC) #4
brandtr
On 2016/11/15 08:43:00, nisse-webrtc wrote: > I'm afraid I'd need a little more context to ...
4 years, 1 month ago (2016-11-15 11:37:16 UTC) #5
brandtr
Rebase.
4 years, 1 month ago (2016-11-15 14:36:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2500943002/20001
4 years, 1 month ago (2016-11-15 15:08:57 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 15:10:55 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 15:11:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/841de6a47e6eb1b190ef6a9b1203ecc53c25f6a3
Cr-Commit-Position: refs/heads/master@{#15087}

Powered by Google App Engine
This is Rietveld 408576698