Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/desktop_capture/rgba_color.h

Issue 2500883004: Add DesktopFrame rotation functions (Closed)
Patch Set: Resolve review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/desktop_capture/desktop_frame_rotator.cc ('K') | « webrtc/modules/desktop_capture/desktop_frame_rotator_unittest.cc ('k') | webrtc/modules/desktop_capture/rgba_color.cc » ('j') | webrtc/modules/desktop_capture/test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/rgba_color.h
diff --git a/webrtc/modules/desktop_capture/rgba_color.h b/webrtc/modules/desktop_capture/rgba_color.h
index 1236d03ee67c21c0c13d4c3802a5936ed97ae13a..c5b6b8d60bd790873813702b7e6daa61cb85349f 100644
--- a/webrtc/modules/desktop_capture/rgba_color.h
+++ b/webrtc/modules/desktop_capture/rgba_color.h
@@ -40,6 +40,10 @@ struct RgbaColor final {
// instance from the ToUInt32() result of another RgbaColor instance.
explicit RgbaColor(uint32_t bgra);
+ // Converts an int to uint32_t, and creates a RGBA instance. This constructor
+ // helps users to write RgbaColor(0) without ambiguous conversion error.
+ explicit RgbaColor(int bgra);
Sergey Ulanov 2016/11/17 02:07:39 Do you still need this?
Hzj_jie 2016/11/17 07:14:55 Yes, it uses in test_utils_unittest.cc.
+
// Returns true if |this| and |right| is the same color.
bool operator==(const RgbaColor& right) const;
« webrtc/modules/desktop_capture/desktop_frame_rotator.cc ('K') | « webrtc/modules/desktop_capture/desktop_frame_rotator_unittest.cc ('k') | webrtc/modules/desktop_capture/rgba_color.cc » ('j') | webrtc/modules/desktop_capture/test_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698