Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Side by Side Diff: webrtc/modules/desktop_capture/test_utils.cc

Issue 2500883004: Add DesktopFrame rotation functions (Closed)
Patch Set: Resolve review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/modules/desktop_capture/test_utils.h"
12
13 #include <string.h>
14
15 #include "webrtc/base/checks.h"
16
17 namespace webrtc {
18
19 void ClearDesktopFrame(DesktopFrame* frame) {
20 RTC_DCHECK(frame);
21 memset(frame->data(), 0, frame->stride() * frame->size().height());
Sergey Ulanov 2016/11/22 20:33:07 stride() may be negative (see https://codesearch.c
Hzj_jie 2016/11/22 21:56:02 Yes, I noticed this class before. Since ClearDeskt
22 }
23
24 bool DesktopFrameDataEquals(const DesktopFrame& left,
25 const DesktopFrame& right) {
26 if (!left.size().equals(right.size())) {
27 return false;
28 }
29 if (left.stride() == right.stride() &&
30 left.stride() == DesktopFrame::kBytesPerPixel * left.size().width()) {
Sergey Ulanov 2016/11/22 20:33:07 I don't think you need this optimization, especial
Hzj_jie 2016/11/22 21:56:02 Done.
31 return memcmp(left.data(),
32 right.data(),
33 left.stride() * left.size().height()) == 0;
34 }
35
36 const uint8_t* my_array = left.data();
Sergey Ulanov 2016/11/22 20:33:07 s/my/left/?
Hzj_jie 2016/11/22 21:56:02 Done.
37 const uint8_t* right_array = right.data();
38 for (int i = 0; i < left.size().height(); i++) {
39 if (memcmp(my_array,
40 right_array,
41 DesktopFrame::kBytesPerPixel * left.size().width()) != 0) {
42 return false;
43 }
44 my_array += left.stride();
45 right_array += right.stride();
46 }
47
48 return true;
49 }
50
51 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/desktop_capture/test_utils.h ('k') | webrtc/modules/desktop_capture/test_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698