Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2500743002: Revert of H.264 packetization mode 0 (try 2) (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of H.264 packetization mode 0 (try 2) (patchset #27 id:520001 of https://codereview.webrtc.org/2337453002/ ) Reason for revert: Broke a lot of tests in chromium.webrtc browser_tests. See e.g. https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62228 and https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30102. [ RUN ] WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264/1 ... # # Fatal error in e:\b\c\b\win_builder\src\third_party\webrtc\modules\rtp_rtcp\source\rtp_format_h264.cc, line 170 # last system error: 0 # Check failed: packetization_mode_ == kH264PacketizationMode1 (0 vs. 2) # Original issue's description: > Implement H.264 packetization mode 0. > > This approach extends the H.264 specific information with > a packetization mode enum. > > Status: Parameter is in code. No way to set it yet. > > Rebase of CL 2009213002 > > BUG=600254 > > Committed: https://crrev.com/3bba101f36483b8030a693dfbc93af736d1dba68 > Cr-Commit-Position: refs/heads/master@{#15032} TBR=hbos@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,hta@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600254 NOPRESUBMIT=true Committed: https://crrev.com/13ceeeadfc81a7ab73f212ebf960c3cc1bfca034 Cr-Commit-Position: refs/heads/master@{#15050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -315 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/common_types.h View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 chunk +5 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 4 chunks +6 lines, -25 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 13 chunks +17 lines, -88 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 6 chunks +11 lines, -57 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_encoder_impl_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 3 chunks +2 lines, -29 lines 0 comments Download
M webrtc/video/payload_router.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
magjed_webrtc
Created Revert of H.264 packetization mode 0 (try 2)
4 years, 1 month ago (2016-11-12 15:24:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2500743002/1
4 years, 1 month ago (2016-11-12 15:24:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10113)
4 years, 1 month ago (2016-11-12 15:29:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2500743002/1
4 years, 1 month ago (2016-11-12 16:46:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-12 16:54:49 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13ceeeadfc81a7ab73f212ebf960c3cc1bfca034 Cr-Commit-Position: refs/heads/master@{#15050}
4 years, 1 month ago (2016-11-12 16:54:53 UTC) #12
hta-webrtc
4 years ago (2016-11-28 09:00:05 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2528343002/ by hta@webrtc.org.

The reason for reverting is: Going to rework this approach a bit based on other
changes.
.

Powered by Google App Engine
This is Rietveld 408576698