Make configuration logic harsher in FlexfecReceiveStream.

Make configuration logic harsher in FlexfecReceiveStream.

Before this change, the configuration logic in FlexfecReceiveStream
tried to make unsupported configurations work, e.g., by dropping the
protection of some media streams when multiple media streams were
protected by a single FlexFEC stream. This CL makes the configuration logic
return more errors on such unsupported configurations.
This harmonizes the logic with the new configuration logic in
VideoSendStream, for the FlexfecSender.

BUG=webrtc:5654
Committed: https://crrev.com/43c31e7afe091fbf01d307f3ff338225e1e6d59e
Cr-Commit-Position: refs/heads/master@{#15083}

[brandtr, 2016-11-14 13:52:14]

Patchset #1 (id:1) has been deleted

[brandtr, 2016-11-14 15:02:00]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org, terelius@webrtc.org

[brandtr, 2016-11-14 15:02:01]

... and on this one, which is related in the sense that it harmonizes the
configuration logic with that of VideoSendStream in the other CL.

[stefan-webrtc, 2016-11-14 15:21:50]

lgtm, see comment.

https://codereview.webrtc.org/2499963002/diff/20001/webrtc/call/flexfec_recei...
File webrtc/call/flexfec_receive_stream.cc (right):

https://codereview.webrtc.org/2499963002/diff/20001/webrtc/call/flexfec_recei...
webrtc/call/flexfec_receive_stream.cc:31: if (config.flexfec_payload_type == -1)
{
< 0?

[brandtr, 2016-11-15 09:19:00]

https://codereview.webrtc.org/2499963002/diff/20001/webrtc/call/flexfec_recei...
File webrtc/call/flexfec_receive_stream.cc (right):

https://codereview.webrtc.org/2499963002/diff/20001/webrtc/call/flexfec_recei...
webrtc/call/flexfec_receive_stream.cc:31: if (config.flexfec_payload_type == -1)
{
On 2016/11/14 15:21:50, stefan-webrtc (holmer) wrote:
> < 0?

Yes, that stricter check makes sense.

[terelius, 2016-11-15 10:01:58]

lgtm % nits

https://codereview.webrtc.org/2499963002/diff/40001/webrtc/call/flexfec_recei...
File webrtc/call/flexfec_receive_stream.cc (right):

https://codereview.webrtc.org/2499963002/diff/40001/webrtc/call/flexfec_recei...
webrtc/call/flexfec_receive_stream.cc:50: LOG(LS_WARNING)
Should this be LS_ERROR?

[brandtr, 2016-11-15 10:28:14]

https://codereview.webrtc.org/2499963002/diff/40001/webrtc/call/flexfec_recei...
File webrtc/call/flexfec_receive_stream.cc (right):

https://codereview.webrtc.org/2499963002/diff/40001/webrtc/call/flexfec_recei...
webrtc/call/flexfec_receive_stream.cc:50: LOG(LS_WARNING)
On 2016/11/15 10:01:58, terelius wrote:
> Should this be LS_ERROR?

Changed all to be WARNINGs, as per offline discussion.

[brandtr, 2016-11-15 10:28:56]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 10:29:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-15 10:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 10:39:23]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16195)

[brandtr, 2016-11-15 11:33:17]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-11-15 11:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2499963002/#ps60001 (title:
"LS_ERROR -> LS_WARNING and 'git cl format'")

[commit-bot: I haz the power, 2016-11-15 11:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-15 13:26:48]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-15 13:26:53]

Description was changed from

==========
Make configuration logic harsher in FlexfecReceiveStream.

Before this change, the configuration logic in FlexfecReceiveStream
tried to make unsupported configurations work, e.g., by dropping the
protection of some media streams when multiple media streams were
protected by a single FlexFEC stream. This CL makes the configuration logic
return more errors on such unsupported configurations.
This harmonizes the logic with the new configuration logic in
VideoSendStream, for the FlexfecSender.

BUG=webrtc:5654
==========

to

==========
Make configuration logic harsher in FlexfecReceiveStream.

Before this change, the configuration logic in FlexfecReceiveStream
tried to make unsupported configurations work, e.g., by dropping the
protection of some media streams when multiple media streams were
protected by a single FlexFEC stream. This CL makes the configuration logic
return more errors on such unsupported configurations.
This harmonizes the logic with the new configuration logic in
VideoSendStream, for the FlexfecSender.

BUG=webrtc:5654

Committed: https://crrev.com/43c31e7afe091fbf01d307f3ff338225e1e6d59e
Cr-Commit-Position: refs/heads/master@{#15083}
==========

[commit-bot: I haz the power, 2016-11-15 13:26:54]

Patchset 3 (id:??) landed as
https://crrev.com/43c31e7afe091fbf01d307f3ff338225e1e6d59e
Cr-Commit-Position: refs/heads/master@{#15083}