Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2499613002: Adds stereo support for Java-based input and output audio on Android (Closed)

Created:
4 years, 1 month ago by henrika_webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds stereo support for Java-based input and output audio on Android BUG=webrtc:6718 Committed: https://crrev.com/779017d989b01b53954636a7237e81dd249e5b84 Cr-Commit-Position: refs/heads/master@{#15104}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Adds WebRtcAudioManager.setStereoMode() API in Java #

Patch Set 4 : nit #

Patch Set 5 : Adds support for separate settings for input and output #

Total comments: 2

Patch Set 6 : Feedback from magjed@ #

Messages

Total messages: 17 (10 generated)
henrika_webrtc
PTAL
4 years, 1 month ago (2016-11-16 13:18:59 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/2499613002/diff/80001/webrtc/modules/audio_device/android/audio_track_jni.h File webrtc/modules/audio_device/android/audio_track_jni.h (right): https://codereview.webrtc.org/2499613002/diff/80001/webrtc/modules/audio_device/android/audio_track_jni.h#newcode145 webrtc/modules/audio_device/android/audio_track_jni.h:145: size_t bytes_per_frame_; Do we need to store this as ...
4 years, 1 month ago (2016-11-16 13:42:09 UTC) #5
henrika_webrtc
Done. Thanks. PTAL https://codereview.webrtc.org/2499613002/diff/80001/webrtc/modules/audio_device/android/audio_track_jni.h File webrtc/modules/audio_device/android/audio_track_jni.h (right): https://codereview.webrtc.org/2499613002/diff/80001/webrtc/modules/audio_device/android/audio_track_jni.h#newcode145 webrtc/modules/audio_device/android/audio_track_jni.h:145: size_t bytes_per_frame_; On 2016/11/16 13:42:09, magjed_webrtc ...
4 years, 1 month ago (2016-11-16 13:56:38 UTC) #8
magjed_webrtc
lgtm
4 years, 1 month ago (2016-11-16 13:59:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2499613002/100001
4 years, 1 month ago (2016-11-16 14:02:29 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-16 14:30:49 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 14:30:56 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/779017d989b01b53954636a7237e81dd249e5b84
Cr-Commit-Position: refs/heads/master@{#15104}

Powered by Google App Engine
This is Rietveld 408576698