Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2499283002: Add support for field trials to event log visualizer. (Closed)

Created:
4 years, 1 month ago by stefan-webrtc
Modified:
4 years, 1 month ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add support for field trials to event log visualizer. BUG=None Committed: https://crrev.com/985d280b46d63e558abfbcb2ccf25238f150206d Cr-Commit-Position: refs/heads/master@{#15086}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/main.cc View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
stefan-webrtc
.
4 years, 1 month ago (2016-11-15 13:38:16 UTC) #1
stefan-webrtc
4 years, 1 month ago (2016-11-15 13:38:37 UTC) #3
terelius
lgtm % one comment https://codereview.webrtc.org/2499283002/diff/40001/webrtc/tools/event_log_visualizer/main.cc File webrtc/tools/event_log_visualizer/main.cc (right): https://codereview.webrtc.org/2499283002/diff/40001/webrtc/tools/event_log_visualizer/main.cc#newcode66 webrtc/tools/event_log_visualizer/main.cc:66: "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/" Several ...
4 years, 1 month ago (2016-11-15 14:18:47 UTC) #4
stefan-webrtc
.
4 years, 1 month ago (2016-11-15 14:34:56 UTC) #5
stefan-webrtc
https://codereview.webrtc.org/2499283002/diff/40001/webrtc/tools/event_log_visualizer/main.cc File webrtc/tools/event_log_visualizer/main.cc (right): https://codereview.webrtc.org/2499283002/diff/40001/webrtc/tools/event_log_visualizer/main.cc#newcode66 webrtc/tools/event_log_visualizer/main.cc:66: "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/" On 2016/11/15 14:18:47, terelius wrote: ...
4 years, 1 month ago (2016-11-15 14:35:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2499283002/60001
4 years, 1 month ago (2016-11-15 14:35:34 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 14:54:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 14:54:23 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/985d280b46d63e558abfbcb2ccf25238f150206d
Cr-Commit-Position: refs/heads/master@{#15086}

Powered by Google App Engine
This is Rietveld 408576698