Chromium Code Reviews

Issue 2499013002: NetEq: Don't interpolate longer than the output size (Closed)

Created:
4 years, 1 month ago by hlundin-webrtc
Modified:
4 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Don't interpolate longer than the output size This can happen in rare and strange cases. Also taking the opportunity to replace all asserts with DCHECKs in that file. BUG=chromium:659225 Committed: https://crrev.com/80c06fa5745a6ff1f03034dfd3fc29a33d12c578 Cr-Commit-Position: refs/heads/master@{#15070}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+18 lines, -12 lines)
M webrtc/modules/audio_coding/neteq/normal.cc View 8 chunks +18 lines, -12 lines 1 comment

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
4 years, 1 month ago (2016-11-14 14:18:22 UTC) #2
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2499013002/diff/1/webrtc/modules/audio_coding/neteq/normal.cc File webrtc/modules/audio_coding/neteq/normal.cc (right): https://codereview.webrtc.org/2499013002/diff/1/webrtc/modules/audio_coding/neteq/normal.cc#newcode140 webrtc/modules/audio_coding/neteq/normal.cc:140: std::min(static_cast<size_t>(8 * fs_mult), output->Size()); Oooh, I just realized ...
4 years, 1 month ago (2016-11-14 14:36:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2499013002/1
4 years, 1 month ago (2016-11-14 14:45:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 16:18:54 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 16:19:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80c06fa5745a6ff1f03034dfd3fc29a33d12c578
Cr-Commit-Position: refs/heads/master@{#15070}

Powered by Google App Engine