Fix parsing padding byte in rtp header extension

Fix parsing padding byte in rtp header extension

BUG=chromium:664598
Committed: https://crrev.com/b7374dba6b45824f45d7fa324ebfb0d52fb4b4f0
Cr-Commit-Position: refs/heads/master@{#15230}

[danilchap, 2016-11-14 10:06:39]

danilchap@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2016-11-14 11:28:18]

lgtm
but should we add a unit test for this as well?

[danilchap, 2016-11-14 13:55:40]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 13:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2016-11-14 14:07:16]

Found and remove old padding handling function (it didn't handle padding in the
beginning of extensions block and assumed all padding was well-formed, i.e. had
len=0)

Added unittest for the RtpUtility::RtpHeaderParser, in particular
ParseWithExtensionPadding that test parser with half-valid padding bytes.

PTAL

[danilchap, 2016-11-24 13:30:14]

ping
Erik, do you want to check added unittests?

[sprang_webrtc, 2016-11-24 16:34:12]

Sorry, lost track. lgtm with nit

https://codereview.webrtc.org/2498903003/diff/100001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtp_utility_unittest.cc (right):

https://codereview.webrtc.org/2498903003/diff/100001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_utility_unittest.cc:165: 0x00,  // Padding to
32bit boundary.
maybe check that this is actual 32bit boundary now, feel like it could easily
break

[danilchap, 2016-11-24 16:48:37]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 16:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2016-11-24 16:50:50]

https://codereview.webrtc.org/2498903003/diff/100001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtp_utility_unittest.cc (right):

https://codereview.webrtc.org/2498903003/diff/100001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_utility_unittest.cc:165: 0x00,  // Padding to
32bit boundary.
On 2016/11/24 16:34:12, språng wrote:
> maybe check that this is actual 32bit boundary now, feel like it could easily
> break

Done.
better check early.
If there is not enough padding, test would fail because parser.Parse would fail,
but it would be harder to understand why.

[commit-bot: I haz the power, 2016-11-24 17:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 17:01:19]

Dry run: This issue passed the CQ dry run.

[danilchap, 2016-11-24 17:04:29]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-11-24 17:04:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2498903003/#ps120001 (title:
"double check packet set correctly")

[commit-bot: I haz the power, 2016-11-24 17:04:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-24 17:06:06]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480007069004820,
"parent_rev": "1fccab5f825299cd50e2016ed45042581d25f4a7", "commit_rev":
"843f983235cfca5e13012c49f991f7da54e9e560"}

[commit-bot: I haz the power, 2016-11-24 17:06:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-24 17:06:23]

Description was changed from

==========
Fix parsing padding byte in rtp header extension

BUG=chromium:664598
==========

to

==========
Fix parsing padding byte in rtp header extension

BUG=chromium:664598

Committed: https://crrev.com/b7374dba6b45824f45d7fa324ebfb0d52fb4b4f0
Cr-Commit-Position: refs/heads/master@{#15230}
==========

[commit-bot: I haz the power, 2016-11-24 17:06:24]

Patchset 7 (id:??) landed as
https://crrev.com/b7374dba6b45824f45d7fa324ebfb0d52fb4b4f0
Cr-Commit-Position: refs/heads/master@{#15230}