webrtc/media/engine/payload_type_mapper_unittest.cc - Issue 2497773003: Use different RTX payload types for different H264 profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/payload_type_mapper_unittest.cc

Issue 2497773003: Use different RTX payload types for different H264 profiles (Closed)

Patch Set: Fix bug and add test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/payload_type_mapper_unittest.cc

diff --git a/webrtc/media/engine/payload_type_mapper_unittest.cc b/webrtc/media/engine/payload_type_mapper_unittest.cc

index 8e00dbc2b708c8b3435e29f9cd607450017929ed..5d6976e666016633c82f122a15670179eb279edf 100644

--- a/webrtc/media/engine/payload_type_mapper_unittest.cc

+++ b/webrtc/media/engine/payload_type_mapper_unittest.cc

@@ -78,7 +78,8 @@ TEST_F(PayloadTypeMapperTest, WebRTCPayloadTypes) {

};

EXPECT_EQ(kDefaultRtxVp8PlType, rtx_mapping(kDefaultVp8PlType));

EXPECT_EQ(kDefaultRtxVp9PlType, rtx_mapping(kDefaultVp9PlType));

- EXPECT_EQ(kDefaultRtxH264PlType, rtx_mapping(kDefaultH264PlType));

+ EXPECT_EQ(kDefaultRtxH264ConstrainedBaselinePlType,

+ rtx_mapping(kDefaultH264PlType));

EXPECT_EQ(kDefaultRtxRedPlType, rtx_mapping(kDefaultRedPlType));

EXPECT_EQ(102, FindMapping({kIlbcCodecName, 8000, 1}));