Android HW encoder: Set constrained baseline as the profile

Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or profile information. No profile-level-id means Baseline Level 1, but we are actually using Contrained Baseline Level 3.1. This CL sets the correct codec parameters.

BUG=webrtc:6337
Committed: https://crrev.com/1da1a09bf5002d8504c0145f651191d33a6d3fe7
Cr-Commit-Position: refs/heads/master@{#15247}

[magjed_webrtc, 2016-11-13 15:48:27]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-13 15:48:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-13 15:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-13 15:53:27]

Dry run: Try jobs failed on following builders:
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/18536)
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/18347)

[magjed_webrtc, 2016-11-23 15:16:51]

Description was changed from

==========
Android HW encoder: Set constrained baseline as the profile

BUG=webrtc:6337
==========

to

==========
Android HW encoder: Set constrained baseline as the profile

BUG=webrtc:6337
==========

[magjed_webrtc, 2016-11-23 15:16:51]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-11-23 15:17:01]

Sami - please take a look.

[magjed_webrtc, 2016-11-23 15:30:12]

Description was changed from

==========
Android HW encoder: Set constrained baseline as the profile

BUG=webrtc:6337
==========

to

==========
Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or
profile information. No profile-level-id means Baseline Level 1, but we are
actually using Contrained Baseline Level 3.1. This CL sets the correct codec
parameters.

BUG=webrtc:6337
==========

[sakal, 2016-11-23 15:35:28]

lgtm

https://codereview.webrtc.org/2497163002/diff/20001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2497163002/diff/20001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidmediaencoder_jni.cc:1350:
constrained_baseline.SetParam(cricket::kH264FmtpLevelAsymmetryAllowed, "1");
nit: add comments for literal values "1" or use constants.

[magjed_webrtc, 2016-11-23 15:38:18]

https://codereview.webrtc.org/2497163002/diff/20001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2497163002/diff/20001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidmediaencoder_jni.cc:1350:
constrained_baseline.SetParam(cricket::kH264FmtpLevelAsymmetryAllowed, "1");
On 2016/11/23 15:35:28, sakal wrote:
> nit: add comments for literal values "1" or use constants.

I think 1 is ok here. 1 means true and 0 means false. The keys, e.g.
kH264FmtpLevelAsymmetryAllowed, serve as comments.

[magjed_webrtc, 2016-11-23 15:38:22]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-11-23 15:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-23 15:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:40:39]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/18672)

[sakal, 2016-11-23 15:52:28]

Is this also the case for the packetization mode? I tried looking into the spec
and it looks like there are 3 modes:

5.4.  Packetization Modes

   This memo specifies three cases of packetization modes:

      o Single NAL unit mode
      o Non-interleaved mode
      o Interleaved mode

[magjed_webrtc, 2016-11-23 16:57:08]

On 2016/11/23 15:52:28, sakal wrote:
> Is this also the case for the packetization mode? I tried looking into the
spec
> and it looks like there are 3 modes:
> 
> 5.4.  Packetization Modes
> 
>    This memo specifies three cases of packetization modes:
> 
>       o Single NAL unit mode
>       o Non-interleaved mode
>       o Interleaved mode

Hmm, I'll have to look into that. If that's the case, then I don't know what 1
stands for. I know Harald has been working on adding more support for
packetization modes and he is only parsing 0 and 1:
https://codereview.webrtc.org/2337453002/diff/520001/webrtc/common_types.h.

[magjed_webrtc, 2016-11-23 16:57:28]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 16:57:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-23 17:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:16:38]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-25 14:07:22]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-11-25 14:07:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2497163002/#ps40001 (title:
"Fix compile failures.")

[commit-bot: I haz the power, 2016-11-25 14:07:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 14:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 14:23:19]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/18733)

[magjed_webrtc, 2016-11-25 14:40:44]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-11-25 14:40:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 14:51:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480084844461940,
"parent_rev": "1b58b0a1e7ddace87f26b098d658719fce55e1f6", "commit_rev":
"9a474afd52e024410524d521b52a7adba9203098"}

[commit-bot: I haz the power, 2016-11-25 14:51:34]

Description was changed from

==========
Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or
profile information. No profile-level-id means Baseline Level 1, but we are
actually using Contrained Baseline Level 3.1. This CL sets the correct codec
parameters.

BUG=webrtc:6337
==========

to

==========
Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or
profile information. No profile-level-id means Baseline Level 1, but we are
actually using Contrained Baseline Level 3.1. This CL sets the correct codec
parameters.

BUG=webrtc:6337
==========

[commit-bot: I haz the power, 2016-11-25 14:51:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-25 14:51:44]

Description was changed from

==========
Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or
profile information. No profile-level-id means Baseline Level 1, but we are
actually using Contrained Baseline Level 3.1. This CL sets the correct codec
parameters.

BUG=webrtc:6337
==========

to

==========
Android HW encoder: Set constrained baseline as the profile

The Android HW encoder is currently not setting any H264 codec parameters or
profile information. No profile-level-id means Baseline Level 1, but we are
actually using Contrained Baseline Level 3.1. This CL sets the correct codec
parameters.

BUG=webrtc:6337

Committed: https://crrev.com/1da1a09bf5002d8504c0145f651191d33a6d3fe7
Cr-Commit-Position: refs/heads/master@{#15247}
==========

[commit-bot: I haz the power, 2016-11-25 14:51:45]

Patchset 3 (id:??) landed as
https://crrev.com/1da1a09bf5002d8504c0145f651191d33a6d3fe7
Cr-Commit-Position: refs/heads/master@{#15247}