Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2496993003: CroppingWindowCapturer::CreateCapturer() function to replace raw pointer version (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

CroppingWindowCapturer::CreateCapturer() function to replace raw pointer version The old CroppingWindowCapturer::Create() function returns a raw pointer, which cannot explain the ownership. So this change adds a CreateCapturer() function to return a unique_ptr. BUG=webrtc:6513 Committed: https://crrev.com/c9a6e4a67ec68d9bc07c1a73ac2a2b54ec484dfa Cr-Commit-Position: refs/heads/master@{#15045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Hzj_jie
4 years, 1 month ago (2016-11-11 22:53:28 UTC) #4
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-11 22:58:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2496993003/1
4 years, 1 month ago (2016-11-11 23:08:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 23:13:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 23:13:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9a6e4a67ec68d9bc07c1a73ac2a2b54ec484dfa
Cr-Commit-Position: refs/heads/master@{#15045}

Powered by Google App Engine
This is Rietveld 408576698