Ensures that AudioDeviceBuffer::StopPeriodicLogging works as intended

webrtc/modules/audio_device/audio_device_buffer.cc

Index: webrtc/modules/audio_device/audio_device_buffer.cc
diff --git a/webrtc/modules/audio_device/audio_device_buffer.cc b/webrtc/modules/audio_device/audio_device_buffer.cc
index 4102a610d10c18a1074f44aa76872b2d4d2de2de..6e8bfbc55284b089759053def317034fcc7d3dca 100644
--- a/webrtc/modules/audio_device/audio_device_buffer.cc
+++ b/webrtc/modules/audio_device/audio_device_buffer.cc
@@ -68,7 +68,8 @@ AudioDeviceBuffer::AudioDeviceBuffer()
       play_stat_count_(0),
       play_start_time_(0),
       rec_start_time_(0),
-      only_silence_recorded_(true) {
+      only_silence_recorded_(true),
+      log_stats_(false) {
   LOG(INFO) << "AudioDeviceBuffer::ctor";
   playout_thread_checker_.DetachFromThread();
   recording_thread_checker_.DetachFromThread();
@@ -429,16 +430,24 @@ void AudioDeviceBuffer::StopPeriodicLogging() {
 void AudioDeviceBuffer::LogStats(LogState state) {
   RTC_DCHECK_RUN_ON(&task_queue_);
   int64_t now_time = rtc::TimeMillis();
+
   if (state == AudioDeviceBuffer::LOG_START) {
     // Reset counters at start. We will not add any logging in this state but
     // the timer will started by posting a new (delayed) task.
     num_stat_reports_ = 0;
     last_timer_task_time_ = now_time;
+    log_stats_ = true;
   } else if (state == AudioDeviceBuffer::LOG_STOP) {
     // Stop logging and posting new tasks.
+    log_stats_ = false;
     return;

[kwiberg-webrtc, 2016/11/11 09:20:49]

Consider eliminating this early return, since it no longer serves a purpose now
that you added another early return on line 450.

[henrika_webrtc, 2016/11/11 10:26:50]

Done.

   } else if (state == AudioDeviceBuffer::LOG_ACTIVE) {
-    // Default state. Just keep on logging.
+    // Keep logging unless logging was disabled while task was posted.
+  }
+
+  // Avoid adding more logs since we are in STOP mode.
+  if (!log_stats_) {
+    return;
   }
 
   int64_t next_callback_time = now_time + kTimerIntervalInMilliseconds;