Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2496543002: Ensures that AudioDeviceBuffer::StopPeriodicLogging works as intended (Closed)

Created:
4 years, 1 month ago by henrika_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensures that AudioDeviceBuffer::StopPeriodicLogging works as intended. Minor fix to resolve https://bugs.chromium.org/p/webrtc/issues/detail?id=6560&desc=2#c5 BUG=webrtc:6560 NOTRY=TRUE Committed: https://crrev.com/0b3a6389c054dff7cc9da10a326eedbd4d9f5e61 Cr-Commit-Position: refs/heads/master@{#15036}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Feedback from kwiberg@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 1 2 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
henrika_webrtc
PTAL
4 years, 1 month ago (2016-11-10 14:23:11 UTC) #4
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2496543002/diff/20001/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2496543002/diff/20001/webrtc/modules/audio_device/audio_device_buffer.cc#newcode443 webrtc/modules/audio_device/audio_device_buffer.cc:443: return; Consider eliminating this early return, since it ...
4 years, 1 month ago (2016-11-11 09:20:49 UTC) #9
henrika_webrtc
Thanks. Done. https://codereview.webrtc.org/2496543002/diff/20001/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2496543002/diff/20001/webrtc/modules/audio_device/audio_device_buffer.cc#newcode443 webrtc/modules/audio_device/audio_device_buffer.cc:443: return; On 2016/11/11 09:20:49, kwiberg-webrtc wrote: > ...
4 years, 1 month ago (2016-11-11 10:26:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2496543002/40001
4 years, 1 month ago (2016-11-11 10:27:21 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 10:28:53 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 10:29:05 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b3a6389c054dff7cc9da10a326eedbd4d9f5e61
Cr-Commit-Position: refs/heads/master@{#15036}

Powered by Google App Engine
This is Rietveld 408576698