Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2496323004: Make setup_links.py not fail if Chromium checkout is missing. (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make setup_links.py not fail if Chromium checkout is missing. If a checkout has been created but haven't yet executed gclient runhooks, running setup_links.py --clean-only will fail if the Chromium checkout isn't yet synced. This can make bots end up in a bad state since we now clean all links before running bot_update. Relaxing this error solves that problem. BUG=chromium:663278 TBR=ehmaldonado@webrtc.org NOTRY=True Committed: https://chromium.googlesource.com/external/webrtc/+/edec0769aacba3edfca02046b8dcebaa57efebf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M setup_links.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_webrtc
This should resolve errors like this https://build.chromium.org/p/tryserver.webrtc/builders/win_compile_rel/builds/584/steps/clean%20symlinks/logs/stdio
4 years, 1 month ago (2016-11-15 21:37:52 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as edec0769aacba3edfca02046b8dcebaa57efebf1 (presubmit successful).
4 years, 1 month ago (2016-11-15 21:39:30 UTC) #4
ehmaldonado_webrtc
4 years, 1 month ago (2016-11-16 09:01:46 UTC) #5
Message was sent while issue was closed.
On 2016/11/15 21:39:30, kjellander_webrtc wrote:
> Committed patchset #1 (id:1) manually as
> edec0769aacba3edfca02046b8dcebaa57efebf1 (presubmit successful).

LGTM.

Powered by Google App Engine
This is Rietveld 408576698