Update RTPSender::IsFecPacket for FlexFEC.

Update RTPSender::IsFecPacket for FlexFEC.

BUG=webrtc:5654
Committed: https://crrev.com/9e795c6ad85b57750e57db8d3883a144c024062e
Cr-Commit-Position: refs/heads/master@{#15067}

[brandtr, 2016-11-14 08:01:33]

brandtr@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[brandtr, 2016-11-14 08:01:34]

Please take a look :)

I missed this function in an earlier CL, and it doesn't really fit into the RTP
packet history wire-up CL.

Proper fixing of the stats for FlexFEC will come later.

https://codereview.webrtc.org/2496113003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (left):

https://codereview.webrtc.org/2496113003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:816: const bool fec_enabled =
(pt_fec != -1);
This was weird. If for some reason a FEC packet was sent to this function, when
FEC was disabled, it would not be counted as a FEC packet. Even though it was a
FEC packet...?

[brandtr, 2016-11-14 08:03:12]

Rebase on top of master.

[danilchap, 2016-11-14 10:23:39]

lgtm

https://codereview.webrtc.org/2496113003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (left):

https://codereview.webrtc.org/2496113003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:816: const bool fec_enabled =
(pt_fec != -1);
On 2016/11/14 08:01:34, brandtr wrote:
> This was weird. If for some reason a FEC packet was sent to this function,
when
> FEC was disabled, it would not be counted as a FEC packet. Even though it was
a
> FEC packet...?

look like leftover from older refactorings, agree not needed now since
static_cast<int>(uint8_t) can't be -1.

it is not obvious what would happen if for some reason payload() will return
signed char* instead,
Still shouldn't be needed since pt_fec can't be more that 127 (DCHECKed when it
is set)

[brandtr, 2016-11-14 11:31:58]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-14 11:32:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-14 11:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 11:37:52]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16138)

[brandtr, 2016-11-14 13:15:22]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-14 13:15:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-14 13:37:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 13:37:30]

Description was changed from

==========
Update RTPSender::IsFecPacket for FlexFEC.

BUG=webrtc:5654
==========

to

==========
Update RTPSender::IsFecPacket for FlexFEC.

BUG=webrtc:5654

Committed: https://crrev.com/9e795c6ad85b57750e57db8d3883a144c024062e
Cr-Commit-Position: refs/heads/master@{#15067}
==========

[commit-bot: I haz the power, 2016-11-14 13:37:31]

Patchset 2 (id:??) landed as
https://crrev.com/9e795c6ad85b57750e57db8d3883a144c024062e
Cr-Commit-Position: refs/heads/master@{#15067}