Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2496113002: Roll chromium_revision 1a6cf4da7c..f1e2718a3f (431807:431838) (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 1a6cf4da7c..f1e2718a3f (431807:431838) Use system Xcode on Mac instead of the hermetic toolchain which is now the default in Chromium. WebRTC needs the 10.12 SDK to compile successfully, which is not availble in the hermetic toolchain Chromium is rolling out to Googlers. Change log: https://chromium.googlesource.com/chromium/src/+log/1a6cf4da7c..f1e2718a3f Full diff: https://chromium.googlesource.com/chromium/src/+/1a6cf4da7c..f1e2718a3f No dependencies changed. No update to Clang. TBR=ehmaldonado@webrtc.org BUG=webrtc:6700 Committed: https://crrev.com/218f436713edabf00e1429ce5c202ab691d93c79 Cr-Commit-Position: refs/heads/master@{#15057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/build.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Running only failed trybots from https://codereview.webrtc.org/2494393002/
4 years, 1 month ago (2016-11-14 07:14:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2496113002/1
4 years, 1 month ago (2016-11-14 07:29:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 07:54:32 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 07:54:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218f436713edabf00e1429ce5c202ab691d93c79
Cr-Commit-Position: refs/heads/master@{#15057}

Powered by Google App Engine
This is Rietveld 408576698