Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Issue 2495253002: Update header formatterts to FlexFEC draft 03. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update header formatters to FlexFEC draft 03. The only difference is that the F and R bits have changed place. BUG=webrtc:5654 Committed: https://crrev.com/25b57ce08ec50afba780c9ae2c560248665a140f Cr-Commit-Position: refs/heads/master@{#15064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M webrtc/modules/rtp_rtcp/source/flexfec_header_reader_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_header_reader_writer.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_header_reader_writer_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-14 10:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2495253002/1
4 years, 1 month ago (2016-11-14 11:38:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/3118)
4 years, 1 month ago (2016-11-14 12:06:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2495253002/1
4 years, 1 month ago (2016-11-14 12:11:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 12:28:58 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 12:29:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25b57ce08ec50afba780c9ae2c560248665a140f
Cr-Commit-Position: refs/heads/master@{#15064}

Powered by Google App Engine
This is Rietveld 408576698