Add ToString method to AggregatedStats and log stats at the end of a call.

Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
Committed: https://crrev.com/43cb716e55eab1cf1ae8afd2ac79b51a604d0fa5
Cr-Commit-Position: refs/heads/master@{#15088}

[åsapersson, 2016-11-14 16:52:27]

Description was changed from

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
==========

to

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
==========

[åsapersson, 2016-11-14 16:52:27]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[åsapersson, 2016-11-14 16:52:51]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 16:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2016-11-14 17:09:43]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-14 17:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 17:17:22]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-11-15 08:38:39]

Very nice!

Only question I have is if we may want to have a helper function which both
updates histograms and logs? Something like:

void UpdateHistogramsAndLog(const std::string& name, const AggregatedStats&
stats);

[åsapersson, 2016-11-15 15:32:23]

On 2016/11/15 08:38:39, stefan-webrtc (holmer) wrote:
> Very nice!
> 
> Only question I have is if we may want to have a helper function which both
> updates histograms and logs? Something like:
> 
> void UpdateHistogramsAndLog(const std::string& name, const AggregatedStats&
> stats);

For the histograms, the name needs to be unique per macro (since the histogram
pointer is cached).

[stefan-webrtc, 2016-11-15 16:10:39]

lgtm based on offline discussion

[åsapersson, 2016-11-15 16:18:47]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-11-15 16:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-15 16:20:50]

Description was changed from

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
==========

to

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
==========

[commit-bot: I haz the power, 2016-11-15 16:20:51]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-11-15 16:21:00]

Description was changed from

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283
==========

to

==========
Add ToString method to AggregatedStats and log stats at the end of a call.

BUG=webrtc:5283

Committed: https://crrev.com/43cb716e55eab1cf1ae8afd2ac79b51a604d0fa5
Cr-Commit-Position: refs/heads/master@{#15088}
==========

[commit-bot: I haz the power, 2016-11-15 16:21:01]

Patchset 1 (id:??) landed as
https://crrev.com/43cb716e55eab1cf1ae8afd2ac79b51a604d0fa5
Cr-Commit-Position: refs/heads/master@{#15088}