Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: webrtc/video/vie_encoder.h

Issue 2493893003: Turn off error resilience for vp8 for no temporal layers if nack is enabled. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_encoder.h
diff --git a/webrtc/video/vie_encoder.h b/webrtc/video/vie_encoder.h
index 433e9ceb5eb0ae2ad2a95ee97bcfb9b27fbd6ce3..8373a3f51d587c3bfba9ac804233a36c5d828599 100644
--- a/webrtc/video/vie_encoder.h
+++ b/webrtc/video/vie_encoder.h
@@ -92,7 +92,8 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
void SetStartBitrate(int start_bitrate_bps);
void ConfigureEncoder(VideoEncoderConfig config,
- size_t max_data_payload_length);
+ size_t max_data_payload_length,
+ bool nack_enabled);
// Permanently stop encoding. After this method has returned, it is
// guaranteed that no encoded frames will be delivered to the sink.
@@ -140,7 +141,8 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
};
void ConfigureEncoderOnTaskQueue(VideoEncoderConfig config,
- size_t max_data_payload_length);
+ size_t max_data_payload_length,
+ bool nack_enabled);
void ReconfigureEncoder();
// Implements VideoSinkInterface.
@@ -193,6 +195,7 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
rtc::Optional<VideoFrameInfo> last_frame_info_ ACCESS_ON(&encoder_queue_);
uint32_t encoder_start_bitrate_bps_ ACCESS_ON(&encoder_queue_);
size_t max_data_payload_length_ ACCESS_ON(&encoder_queue_);
+ bool nack_enabled_ ACCESS_ON(&encoder_queue_);
uint32_t last_observed_bitrate_bps_ ACCESS_ON(&encoder_queue_);
bool encoder_paused_and_dropped_frame_ ACCESS_ON(&encoder_queue_);
bool has_received_sli_ ACCESS_ON(&encoder_queue_);
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698