Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: webrtc/video/vie_encoder.h

Issue 2493893003: Turn off error resilience for vp8 for no temporal layers if nack is enabled. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/vie_encoder.h
diff --git a/webrtc/video/vie_encoder.h b/webrtc/video/vie_encoder.h
index b89f66e9d9707a2ee8484368aefd1abf978c0c07..c6fc43d2dd54444eddcb753c36a431ea3d702248 100644
--- a/webrtc/video/vie_encoder.h
+++ b/webrtc/video/vie_encoder.h
@@ -92,7 +92,8 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
void SetStartBitrate(int start_bitrate_bps);
void ConfigureEncoder(VideoEncoderConfig config,
- size_t max_data_payload_length);
+ size_t max_data_payload_length,
+ bool nack_enabled);
// Permanently stop encoding. After this method has returned, it is
// guaranteed that no encoded frames will be delivered to the sink.
@@ -140,7 +141,8 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
};
void ConfigureEncoderOnTaskQueue(VideoEncoderConfig config,
- size_t max_data_payload_length);
+ size_t max_data_payload_length,
+ bool nack_enabled);
void ReconfigureEncoder();
// Implements VideoSinkInterface.
@@ -196,6 +198,7 @@ class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
rtc::Optional<VideoFrameInfo> last_frame_info_ ACCESS_ON(&encoder_queue_);
uint32_t encoder_start_bitrate_bps_ ACCESS_ON(&encoder_queue_);
size_t max_data_payload_length_ ACCESS_ON(&encoder_queue_);
+ bool nack_enabled_ ACCESS_ON(&encoder_queue_);
uint32_t last_observed_bitrate_bps_ ACCESS_ON(&encoder_queue_);
bool encoder_paused_and_dropped_frame_ ACCESS_ON(&encoder_queue_);
bool has_received_sli_ ACCESS_ON(&encoder_queue_);

Powered by Google App Engine
This is Rietveld 408576698