Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: webrtc/video/video_send_stream.cc

Issue 2493893003: Turn off error resilience for vp8 for no temporal layers if nack is enabled. (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/video_codec_initializer.cc ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/video/video_send_stream.h" 10 #include "webrtc/video/video_send_stream.h"
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 rtc::VideoSourceInterface<webrtc::VideoFrame>* source, 629 rtc::VideoSourceInterface<webrtc::VideoFrame>* source,
630 const DegradationPreference& degradation_preference) { 630 const DegradationPreference& degradation_preference) {
631 RTC_DCHECK_RUN_ON(&thread_checker_); 631 RTC_DCHECK_RUN_ON(&thread_checker_);
632 vie_encoder_->SetSource(source, degradation_preference); 632 vie_encoder_->SetSource(source, degradation_preference);
633 } 633 }
634 634
635 void VideoSendStream::ReconfigureVideoEncoder(VideoEncoderConfig config) { 635 void VideoSendStream::ReconfigureVideoEncoder(VideoEncoderConfig config) {
636 // TODO(perkj): Some test cases in VideoSendStreamTest call 636 // TODO(perkj): Some test cases in VideoSendStreamTest call
637 // ReconfigureVideoEncoder from the network thread. 637 // ReconfigureVideoEncoder from the network thread.
638 // RTC_DCHECK_RUN_ON(&thread_checker_); 638 // RTC_DCHECK_RUN_ON(&thread_checker_);
639 vie_encoder_->ConfigureEncoder(std::move(config), 639 vie_encoder_->ConfigureEncoder(std::move(config), config_.rtp.max_packet_size,
640 config_.rtp.max_packet_size); 640 config_.rtp.nack.rtp_history_ms > 0);
641 } 641 }
642 642
643 VideoSendStream::Stats VideoSendStream::GetStats() { 643 VideoSendStream::Stats VideoSendStream::GetStats() {
644 // TODO(perkj, solenberg): Some test cases in EndToEndTest call GetStats from 644 // TODO(perkj, solenberg): Some test cases in EndToEndTest call GetStats from
645 // a network thread. See comment in Call::GetStats(). 645 // a network thread. See comment in Call::GetStats().
646 // RTC_DCHECK_RUN_ON(&thread_checker_); 646 // RTC_DCHECK_RUN_ON(&thread_checker_);
647 return stats_proxy_.GetStats(); 647 return stats_proxy_.GetStats();
648 } 648 }
649 649
650 void VideoSendStream::SignalNetworkState(NetworkState state) { 650 void VideoSendStream::SignalNetworkState(NetworkState state) {
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1212 } 1212 }
1213 1213
1214 void VideoSendStreamImpl::SetTransportOverhead( 1214 void VideoSendStreamImpl::SetTransportOverhead(
1215 int transport_overhead_per_packet) { 1215 int transport_overhead_per_packet) {
1216 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) 1216 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
1217 rtp_rtcp->SetTransportOverhead(transport_overhead_per_packet); 1217 rtp_rtcp->SetTransportOverhead(transport_overhead_per_packet);
1218 } 1218 }
1219 1219
1220 } // namespace internal 1220 } // namespace internal
1221 } // namespace webrtc 1221 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/video_codec_initializer.cc ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698