Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2493873005: Remove unused warning suppression (Closed)

Created:
4 years, 1 month ago by kthelgason
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused warning suppression We want to keep these warnings on. They were switched off temporarily to unblock chromium roll. BUG=webrtc:6520 Committed: https://crrev.com/74f9d981d0d0e831df834273292ae89eb26ca8aa Cr-Commit-Position: refs/heads/master@{#15043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/examples/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
PTAL
4 years, 1 month ago (2016-11-11 12:25:20 UTC) #2
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-11-11 13:10:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493873005/1
4 years, 1 month ago (2016-11-11 13:41:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 14:09:24 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 14:09:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74f9d981d0d0e831df834273292ae89eb26ca8aa
Cr-Commit-Position: refs/heads/master@{#15043}

Powered by Google App Engine
This is Rietveld 408576698