Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2493483002: Created a mock AudioTransport. (Closed)

Created:
4 years, 1 month ago by aleloi
Modified:
4 years, 1 month ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Created a mocked AudioTransport. There are currently two nearly identical classes called MockAudioTransport defined in two unit tests: android/audio_transport_unittest.cc and /ios/audio_transport_unittest_ios.cc This change defines a common mocked AudioTransport. The two current mocks are rewritten to use the common one. A GN target is created for this mock and MockAudioDevice. This change will allow to provide a mocked AudioTransport to AudioState in a dependent CL https://codereview.webrtc.org/2454373002/ BUG=webrtc:6346 NOPRESUBMIT=True Committed: https://crrev.com/5de52fd38e8d80250d6e8ed79764ded1f39d4b5d Cr-Commit-Position: refs/heads/master@{#15010}

Patch Set 1 : put cflags where it belongs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -104 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 9 chunks +13 lines, -51 lines 0 comments Download
A webrtc/modules/audio_device/include/mock_audio_transport.h View 1 chunk +68 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 11 chunks +15 lines, -53 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
aleloi
Hi! Can you take a look at this?
4 years, 1 month ago (2016-11-09 17:05:21 UTC) #11
henrika_webrtc
It looks great but you should ensure that it works on real devices. I think ...
4 years, 1 month ago (2016-11-09 17:14:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493483002/100001
4 years, 1 month ago (2016-11-09 17:43:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10000)
4 years, 1 month ago (2016-11-09 17:45:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493483002/100001
4 years, 1 month ago (2016-11-10 09:05:20 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 1 month ago (2016-11-10 09:05:37 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 09:05:46 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5de52fd38e8d80250d6e8ed79764ded1f39d4b5d
Cr-Commit-Position: refs/heads/master@{#15010}

Powered by Google App Engine
This is Rietveld 408576698