Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2493413002:
Use a default mouse cursor if XFixes is not supported. (Closed)
|
Created:
4 years, 1 month ago by Jamie Modified:
4 years, 1 month ago Reviewers:
Sergey Ulanov CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUse a default mouse cursor if XFixes is not supported.
BUG=chromium:428886
Committed: https://crrev.com/69a0e3edea3d61f665520b930920f8a9b2078e41
Cr-Commit-Position: refs/heads/master@{#15074}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Reviewer feedback. #Messages
Total messages: 20 (10 generated)
jamiewalch@chromium.org changed reviewers: + sergeyu@chromium.org
ptal
lgtm with 2 nits https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc (right): https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:105: uint8_t* ptr = default_cursor->data(); nit: move this just before the for loop, closre to where it's used. https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:106: DesktopVector hotspot(2, 2); nit: move this after the for loops below, closer to where it's used/
FYI https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc (right): https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:105: uint8_t* ptr = default_cursor->data(); On 2016/11/12 07:22:54, Sergey Ulanov wrote: > nit: move this just before the for loop, closre to where it's used. Done. https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:106: DesktopVector hotspot(2, 2); On 2016/11/12 07:22:54, Sergey Ulanov wrote: > nit: move this after the for loops below, closer to where it's used/ Done.
The CQ bit was checked by jamiewalch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.webrtc.org/2493413002/#ps20001 (title: "Reviewer feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10177)
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10182)
Description was changed from ========== Use a default mouse cursor if XFixes is not supported. ========== to ========== Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 ==========
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 ========== to ========== Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 ========== to ========== Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 Committed: https://crrev.com/69a0e3edea3d61f665520b930920f8a9b2078e41 Cr-Commit-Position: refs/heads/master@{#15074} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/69a0e3edea3d61f665520b930920f8a9b2078e41 Cr-Commit-Position: refs/heads/master@{#15074} |
