Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2493413002: Use a default mouse cursor if XFixes is not supported. (Closed)

Created:
4 years, 1 month ago by Jamie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a default mouse cursor if XFixes is not supported. BUG=chromium:428886 Committed: https://crrev.com/69a0e3edea3d61f665520b930920f8a9b2078e41 Cr-Commit-Position: refs/heads/master@{#15074}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc View 1 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
Jamie
ptal
4 years, 1 month ago (2016-11-12 02:00:16 UTC) #2
Sergey Ulanov
lgtm with 2 nits https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc File webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc (right): https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc#newcode105 webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:105: uint8_t* ptr = default_cursor->data(); nit: ...
4 years, 1 month ago (2016-11-12 07:22:54 UTC) #3
Jamie
FYI https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc File webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc (right): https://codereview.webrtc.org/2493413002/diff/1/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc#newcode105 webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:105: uint8_t* ptr = default_cursor->data(); On 2016/11/12 07:22:54, Sergey ...
4 years, 1 month ago (2016-11-14 18:12:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493413002/20001
4 years, 1 month ago (2016-11-14 18:12:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10177)
4 years, 1 month ago (2016-11-14 18:15:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493413002/20001
4 years, 1 month ago (2016-11-14 19:09:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10182)
4 years, 1 month ago (2016-11-14 19:13:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493413002/20001
4 years, 1 month ago (2016-11-15 02:01:34 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 02:04:35 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 02:04:47 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69a0e3edea3d61f665520b930920f8a9b2078e41
Cr-Commit-Position: refs/heads/master@{#15074}

Powered by Google App Engine
This is Rietveld 408576698