Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m

Issue 2492693003: Propagate bitrate setting to RTCRtpSender. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m
diff --git a/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m b/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m
index 61b5c506bd3bce9ace07d8db66a021ceeea97c18..eda02758198cfe7e5a2e09a5c89fd43ac1d6bc87 100644
--- a/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m
+++ b/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m
@@ -29,11 +29,11 @@ static NSArray<NSString *> *videoResolutionsStaticValues() {
}
- (NSString *)currentVideoResoultionConstraintFromStore {
- NSString *constraint = [[self settingsStore] videoResolutionConstraintsSetting];
+ NSString *constraint = [[self settingsStore] videoResolutionConstraints];
if (!constraint) {
constraint = [self defaultVideoResolutionMediaConstraint];
// To ensure consistency add the default to the store.
- [[self settingsStore] setVideoResolutionConstraintsSetting:constraint];
+ [[self settingsStore] setVideoResolutionConstraints:constraint];
}
return constraint;
}
@@ -42,10 +42,18 @@ static NSArray<NSString *> *videoResolutionsStaticValues() {
if (![[self availableVideoResoultionsMediaConstraints] containsObject:constraint]) {
return NO;
}
- [[self settingsStore] setVideoResolutionConstraintsSetting:constraint];
+ [[self settingsStore] setVideoResolutionConstraints:constraint];
return YES;
}
+- (nullable NSNumber *)currentMaxBitrateSettingFromStore {
+ return [[self settingsStore] maxBitrate];
+}
+
+- (void)storeMaxBitrateSetting:(nullable NSNumber *)bitrate {
+ [[self settingsStore] setMaxBitrate:bitrate];
+}
+
#pragma mark - Testable
- (ARDSettingsStore *)settingsStore {
« no previous file with comments | « webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.h ('k') | webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698