Propagate bitrate setting to RTCRtpSender.

webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m

Index: webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m
diff --git a/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m b/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m
index 6b3642e00697f1581b04a487ae86da6f22f49818..a767f0f083b5fa8f3d903b921d6b2bed45c11d5e 100644
--- a/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m
+++ b/webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsStore.m
@@ -12,17 +12,29 @@
 
 static NSString *const kUserDefaultsMediaConstraintsKey =
     @"rtc_video_resolution_media_constraints_key";
+static NSString *const kUserDefaultsBitrateKey = @"rtc_max_bitrate_key";

[magjed_webrtc, 2016/11/11 08:45:05]

Why do these variable names contain 'UserDefaults'? I.e. wouldn't kBitrateKey be
enough?

[daniela-webrtc, 2016/11/11 13:45:12]

No rule enforcing the UserDefaults in the name. I just like descriptive names
(in true ObjC fashion) :D

[magjed_webrtc, 2016/11/14 13:05:27]

I understand we can name the variable whatever and it will still compile. What I
don't understand is why 'UserDefaults' is good to have in these variable names.
For me this variable looks just like a key and including 'UserDefaults' is
confusing for me since I interpret it as the key can be overridden. I see that
we use these keys in an NSUserDefaults object below and that's where the name
must come from, but for me it's confusing rather than descriptive.

[daniela-webrtc, 2016/11/14 13:36:15]

Done.

 
 NS_ASSUME_NONNULL_BEGIN
 @implementation ARDSettingsStore
 
+- (NSUserDefaults *)storage {
+  return [NSUserDefaults standardUserDefaults];
+}
+
 - (nullable NSString *)videoResolutionConstraintsSetting {
-  return [[NSUserDefaults standardUserDefaults] objectForKey:kUserDefaultsMediaConstraintsKey];
+  return [[self storage] objectForKey:kUserDefaultsMediaConstraintsKey];
 }
 
 - (void)setVideoResolutionConstraintsSetting:(NSString *)constraintsString {
-  [[NSUserDefaults standardUserDefaults] setObject:constraintsString
-                                            forKey:kUserDefaultsMediaConstraintsKey];
+  [[self storage] setObject:constraintsString forKey:kUserDefaultsMediaConstraintsKey];
+}
+
+- (nullable NSNumber *)maxBitrateSetting {
+  return [[self storage] objectForKey:kUserDefaultsBitrateKey];
+}
+
+- (void)setMaxBitrateSetting:(nullable NSNumber *)value {
+  [[self storage] setObject:value forKey:kUserDefaultsBitrateKey];
 }
 
 @end